Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEC-310 - Documentation update for the org.apache.commons.codec.digest.* package #208

Merged
merged 1 commit into from Sep 28, 2023

Conversation

yakovsh
Copy link
Contributor

@yakovsh yakovsh commented Sep 28, 2023

This PR:

  • Documents that SecureRandom is used in Crypt, Md5Crypt and Sha2Crypt classes by changing Javadocs in these classes (by calling B64.randomSalt)
  • Changes salt generation in UnixCrypt to use SecureRandom to match the other classes
  • Update the userguide to list all functions from the digest package
  • Changes the hyperlinks in the user guide from HTTP to HTTPS

See https://issues.apache.org/jira/browse/CODEC-310

@codecov-commenter
Copy link

Codecov Report

Merging #208 (22c3d4c) into master (fab2cf8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #208   +/-   ##
=========================================
  Coverage     92.21%   92.21%           
  Complexity     1740     1740           
=========================================
  Files            67       67           
  Lines          4584     4584           
  Branches        709      709           
=========================================
  Hits           4227     4227           
  Misses          244      244           
  Partials        113      113           
Files Coverage Δ
...in/java/org/apache/commons/codec/digest/Crypt.java 100.00% <ø> (ø)
...java/org/apache/commons/codec/digest/Md5Crypt.java 100.00% <ø> (ø)
...ava/org/apache/commons/codec/digest/Sha2Crypt.java 94.02% <ø> (ø)
...ava/org/apache/commons/codec/digest/UnixCrypt.java 98.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garydgregory garydgregory merged commit 14c2f60 into apache:master Sep 28, 2023
6 checks passed
@garydgregory
Copy link
Member

Patch applied. TY @yakovsh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants