-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore methods with optional params for 4.19 compatability #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
c2b957e
to
3331712
Compare
@vishesh92 |
I checked the diff betwen this PR and latest v2.15.0
|
thanks @vishesh92 it looks terraform will not work
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked the diff between v2.15.0 and this PR, did not find other compatibility issues except the guest OS
I think it is good to merge. @vishesh92 thanks
After merging PR #80, optional params always needs to be set. In case of the optional parameter of type UUID, the only option is to set the value to an empty string. This results in a request to ACS with the optional parameter in the request with an empty string. ACS throws an error because it can't find the associated id in the database. Actual change is only in generate.go. Rest of the changes are in generated code.
Add optional params from #77 to the
requiredParams.go
.