Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus image hardcoded #4756

Closed
squakez opened this issue Sep 18, 2023 · 1 comment · Fixed by #4813
Closed

Quarkus image hardcoded #4756

squakez opened this issue Sep 18, 2023 · 1 comment · Fixed by #4813
Assignees
@squakez
Labels
area/quarkus Related to the Quarkus runtime camel/catalog Related to Camel catalog usage
Milestone
2.1.0

Comments

@squakez
Copy link
Contributor

squakez commented Sep 18, 2023 •
edited

We have the image hardcoded [1]. We should use the same approach used for the builder image which is available in the catalog [2].

[1]

camel-k/pkg/builder/image.go

Line 67 in 4b3a8ed

ctx.BaseImage = "quay.io/quarkus/quarkus-distroless-image:1.0"

[2] apache/camel-k-runtime#943
@squakez squakez added area/quarkus Related to the Quarkus runtime camel/catalog Related to Camel catalog usage labels Sep 18, 2023
@squakez squakez added this to the 2.1.0 milestone Sep 18, 2023
@squakez
Copy link
Contributor Author

squakez commented Sep 26, 2023

Something to consider is that we should not use the distroless as targeted as "experimental". Probably it makes sense to change the logic and use the micro image instead.

@squakez squakez self-assigned this Oct 9, 2023
squakez added a commit to squakez/camel-k that referenced this issue Oct 10, 2023
@squakez
feat(trait): quarkus native advanced configuration
ce86bbc 
Closes apache#4756
@squakez squakez mentioned this issue Oct 10, 2023
Merged
squakez added a commit that referenced this issue Oct 11, 2023
@squakez
feat(trait): quarkus native advanced configuration
873e0fd 
Closes #4756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squakez squakez

Labels
area/quarkus Related to the Quarkus runtime camel/catalog Related to Camel catalog usage
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

feat(trait): quarkus native advanced configuration squakez/camel-k
1 participant
@squakez