Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45178: [CI] Remove clcache related codes #45182

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

kou
Copy link
Member

@kou kou commented Jan 6, 2025

Rationale for this change

We don't use clcache anymore.

What changes are included in this PR?

Remove clcache related codes in files except CHANGELOG.md:

$ git grep clcache
CHANGELOG.md:* [ARROW-3167](https://issues.apache.org/jira/browse/ARROW-3167) - [CI] Limit clcache cache size
CHANGELOG.md:* [ARROW-2231](https://issues.apache.org/jira/browse/ARROW-2231) - [CI] Use clcache on AppVeyor for faster builds
CHANGELOG.md:* [ARROW-2238](https://issues.apache.org/jira/browse/ARROW-2238) - [C++] Detect and use clcache in cmake configuration
ci/docker/python-wheel-windows-vs2019.dockerfile:# ENV CLCACHE_DIR="C:\clcache"
ci/docker/python-wheel-windows-vs2019.dockerfile:# RUN pip install git+https://github.com/Nuitka/clcache.git
ci/scripts/python_wheel_windows_build.bat:    -DCMAKE_CXX_COMPILER=clcache ^
docker-compose.yml:  python-wheel-windows-clcache:
docker-compose.yml:    name: python-wheel-windows-clcache
docker-compose.yml:      - "${DOCKER_VOLUME_PREFIX}python-wheel-windows-clcache:C:/clcache"
docker-compose.yml:      - "${DOCKER_VOLUME_PREFIX}python-wheel-windows-clcache:C:/clcache"

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

We don't use clcache anymore.
Copy link

github-actions bot commented Jan 6, 2025

⚠️ GitHub issue #45178 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 6, 2025
@kou
Copy link
Member Author

kou commented Jan 6, 2025

@github-actions crossbow submit wheel-windows-*

Copy link

github-actions bot commented Jan 6, 2025

Revision: d97f9f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-55642b9508

Task Status
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp313-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@assignUser assignUser merged commit 8cff21f into apache:main Jan 7, 2025
37 of 38 checks passed
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Jan 7, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 7, 2025
@kou kou deleted the ci-clcache branch January 7, 2025 02:19
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8cff21f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants