Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLib] Separate version macros for each GLib library #41681

Closed
adamreeve opened this issue May 16, 2024 · 1 comment
Closed

[GLib] Separate version macros for each GLib library #41681

adamreeve opened this issue May 16, 2024 · 1 comment

Comments

@adamreeve
Copy link
Contributor

Describe the enhancement requested

In order to support building the GLib libraries with MSVC and correctly applying dllimport and dllexport attributes depending on whether a library is being compiled or consumed, we should have separate *_AVAILALBLE_IN_* and *_DEPRECATED_IN_* macros for each GLib library.

See discussion at #41599 (comment)

Component(s)

GLib

kou added a commit that referenced this issue May 22, 2024
…ry (#41721)

### Rationale for this change

This is to support later using the `*_AVAILABLE_IN_*` macros to add `dllexport/dllimport` attributes required for building these libraries with MSVC (#41134)

### What changes are included in this PR?

* Add a Python script that generates `DEPRECATED_IN` and `AVAILABLE_IN` macros for each GLib library
* Add missing `AVAILABLE_IN` annotations to some methods in the GLib libraries (except the main arrow-glib library as this is being done in #41599)

### Are these changes tested?

This doesn't include any behaviour change that can be unit tested.

### Are there any user-facing changes?

No
* GitHub Issue: #41681

Lead-authored-by: Adam Reeve <adreeve@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 17.0.0 milestone May 22, 2024
@kou
Copy link
Member

kou commented May 22, 2024

Issue resolved by pull request 41721
#41721

@kou kou closed this as completed May 22, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
… library (apache#41721)

### Rationale for this change

This is to support later using the `*_AVAILABLE_IN_*` macros to add `dllexport/dllimport` attributes required for building these libraries with MSVC (apache#41134)

### What changes are included in this PR?

* Add a Python script that generates `DEPRECATED_IN` and `AVAILABLE_IN` macros for each GLib library
* Add missing `AVAILABLE_IN` annotations to some methods in the GLib libraries (except the main arrow-glib library as this is being done in apache#41599)

### Are these changes tested?

This doesn't include any behaviour change that can be unit tested.

### Are there any user-facing changes?

No
* GitHub Issue: apache#41681

Lead-authored-by: Adam Reeve <adreeve@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants