Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39624: [R][CI] Add CMake to docker file and update envvars #39625

Merged
merged 3 commits into from Jan 16, 2024

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Jan 16, 2024

Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

Are these changes tested?

Crossbos

Copy link

⚠️ GitHub issue #39624 has been automatically assigned in GitHub to PR creator.

@assignUser
Copy link
Member Author

assignUser commented Jan 16, 2024

@github-actions crossbow submit -g r

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 16, 2024
Copy link

Revision: 2c97109

Submitted crossbow builds: ursacomputing/crossbow @ actions-65d2e156c3

Task Status
r-binary-packages GitHub Actions
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-library-r-base-latest Azure
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rstudio-r-base-4.1-opensuse153 Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-r-sanitizer Azure

@assignUser
Copy link
Member Author

assignUser commented Jan 16, 2024

The depsource build fails because of #39628 the other fails seem unrelated as they are not during the package build process this PR alters.

@assignUser assignUser merged commit ac50918 into apache:main Jan 16, 2024
53 of 54 checks passed
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Jan 16, 2024
@assignUser assignUser deleted the fix-r-ci branch January 16, 2024 03:51
raulcd pushed a commit that referenced this pull request Jan 16, 2024
### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: #39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ac50918.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

assignUser added a commit that referenced this pull request Jan 16, 2024
### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: #39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
idailylife pushed a commit to idailylife/arrow that referenced this pull request Jan 18, 2024
…pache#39625)

### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: apache#39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…pache#39625)

### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: apache#39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#39625)

### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: apache#39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…pache#39625)

### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: apache#39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…pache#39625)

### Rationale for this change

CMake is now a sysreq and we don't want to default to using nightly builds in CI

### Are these changes tested?

Crossbos
* Closes: apache#39624

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R][CI] Update R docker jobs to work with new build system.
2 participants