GH-39604: [JS] Do not use resizable buffers yet #39607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: JavaScript
awaiting committer review
|
@github-actions crossbow submit js |
|
Revision: 9c1cb93 Submitted crossbow builds: ursacomputing/crossbow @ actions-8a8bb1938f
|
|
Yes, it's ready. |
raulcd
pushed a commit
that referenced
this pull request
Jan 16, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit eec4942. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
idailylife
pushed a commit
to idailylife/arrow
that referenced
this pull request
Jan 18, 2024
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing support for reusable buffers for now since Safari seems to allocate the full memory. We could lower the max buffer size but I am worried that we wouldn't get the size parameter right without enough time.
Reverts #39252