Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Don't download cmake when TEST_OFFLINE_BUILD=true #39601

Closed
nealrichardson opened this issue Jan 14, 2024 · 0 comments · Fixed by #39602
Closed

[R] Don't download cmake when TEST_OFFLINE_BUILD=true #39601

nealrichardson opened this issue Jan 14, 2024 · 0 comments · Fixed by #39602
Assignees
@nealrichardson
Labels
Component: R Type: enhancement
Milestone
15.0.0

Comments

@nealrichardson
Copy link
Member

nealrichardson commented Jan 14, 2024 •
edited

Describe the enhancement requested

Right now we turn off all other kinds of downloading, but we allow cmake to be downloaded if not found of sufficient version.

  • Insert if(!download_ok) return(FALSE) at the beginning of try_download()
  • In find_cmake(), if cmake is found in one of the places, print the version (both when it is new enough and not)
  • Also look for cmake at /Applications/CMake.app/Contents/bin/cmake, where it apparently might be on CRAN
  • Update comments and docs to note that cmake won't be downloaded in this case
  • Add cmake > 3.16 to SystemRequirements, noting that it is build-time only

cc @jonkeane @thisisnic @assignUser

Component(s)

R
nealrichardson added a commit to nealrichardson/arrow that referenced this issue Jan 14, 2024
@nealrichardson
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true
06c1e79
@nealrichardson nealrichardson mentioned this issue Jan 14, 2024
Merged
assignUser pushed a commit that referenced this issue Jan 16, 2024
@nealrichardson
GH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (#39602)
0d128c6 
See #39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: #39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 15.0.0 milestone Jan 16, 2024
raulcd pushed a commit that referenced this issue Jan 16, 2024
@nealrichardson @raulcd
GH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (#39602)
98e5525 
See #39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: #39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser pushed a commit that referenced this issue Jan 16, 2024
@nealrichardson @assignUser
GH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (#39602)
5e37c91 
See #39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: #39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
idailylife pushed a commit to idailylife/arrow that referenced this issue Jan 18, 2024
@nealrichardson @idailylife
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (…
4dc65fc 
…apache#39602)

See apache#39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: apache#39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@nealrichardson @clayburn
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (…
19313fd 
…apache#39602)

See apache#39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: apache#39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@nealrichardson @dgreiss
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (…
ea8cef6 
…apache#39602)

See apache#39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: apache#39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@nealrichardson @zanmato1984
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (…
498f1de 
…apache#39602)

See apache#39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: apache#39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@nealrichardson @thisisnic
apacheGH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true (…
0519317 
…apache#39602)

See apache#39601 

### Are these changes tested?

Existing CI should pass. This should also pass on macbuilder without downloading cmake, and if hardcoding `download_ok <- FALSE`, it should exit cleanly and informatively.

### Are there any user-facing changes?

Define "user".
* Closes: apache#39601

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nealrichardson nealrichardson

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39601: [R] Don't download cmake when TEST_OFFLINE_BUILD=true nealrichardson/arrow
2 participants
@nealrichardson @assignUser