Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Go] The verify-rc-source-integration-macos-conda-amd64 job fails building cdata_integration for go #39588

Closed
raulcd opened this issue Jan 12, 2024 · 1 comment · Fixed by #39589

Comments

@raulcd
Copy link
Member

raulcd commented Jan 12, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The following job:

Has been failing for a long time with:

~/work/crossbow/crossbow/arrow/go/arrow/internal/cdata_integration ~/work/crossbow/crossbow/arrow/go ~/work/crossbow/crossbow/arrow ~/work/crossbow/crossbow
package github.com/apache/arrow/go/v15/arrow/internal/cdata_integration: build constraints exclude all Go files in /Users/runner/work/crossbow/crossbow/arrow/go/arrow/internal/cdata_integration
Failed to verify release candidate. See /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/arrow-HEAD.XXXXX.y35Ie57h for details.
Error: Process completed with exit code 1.

It is being built with TEST_INTEGRATION=1 so the following is currently executed and is where it fails:

  pushd go
  go get -v ./...
  if [ ${TEST_GO} -gt 0 ]; then
    go test ./...
  fi
  go install -buildvcs=false ./...
  if [ ${TEST_INTEGRATION_GO} -gt 0 ]; then
    pushd arrow/internal/cdata_integration
    case "$(uname)" in
      Linux)
        go_lib="arrow_go_integration.so"
        ;;
      Darwin)
        go_lib="arrow_go_integration.dylib"
        ;;
      MINGW*)
        go_lib="arrow_go_integration.dll"
        ;;
    esac
    go build -buildvcs=false -tags cdata_integration,assert -buildmode=c-shared -o ${go_lib} .
    popd
  fi
  go clean -modcache
  popd

See: https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L914-L942

Component(s)

Continuous Integration, Go

@raulcd
Copy link
Member Author

raulcd commented Jan 12, 2024

This is affecting the maintenance branch for 15.0.0 but it does seem to be an issue with the verification script and doesn't seem to be a blocker for the release in my opinion.

raulcd added a commit that referenced this issue Jan 14, 2024
…x macOS build with conda (#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: #39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd raulcd added this to the 15.0.0 milestone Jan 14, 2024
raulcd added a commit that referenced this issue Jan 14, 2024
…x macOS build with conda (#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: #39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
idailylife pushed a commit to idailylife/arrow that referenced this issue Jan 18, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
… to fix macOS build with conda (apache#39589)

### Rationale for this change

CI job has been failing since we added integration tests.

### What changes are included in this PR?

Add `CGO_ENABLED=1` to go build cdata_integration on the verification script.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?

No
* Closes: apache#39588

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment