GH-39074: [Release][Packaging] Use UTF-8 explicitly for KEYS #39082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit almalinux-* centos-* amazonlinux-* |
|
|
@github-actions crossbow submit almalinux-* centos-* amazon-linux-* |
|
Revision: 834a72f Submitted crossbow builds: ursacomputing/crossbow @ actions-ad03727a29
|
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 50e54b8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
Dec 9, 2023
### Rationale for this change `KEYS` may have UTF-8 (non ASCII) characters. Ruby chooses the default encoding based on `LANG`. If `LANG=C`, Ruby uses the `US-ASCII` encoding as the default encoding. If Ruby uses the `US-ASCII` encoding, we can't process `KEYS` because it has non ASCII characters. ### What changes are included in this PR? Use the `UTF-8` encoding explicitly for `KEYS`. If we specify the `UTF-8` encoding explicitly, our `KEYS` processing don't depend on `LANG`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #39074 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#39082) ### Rationale for this change `KEYS` may have UTF-8 (non ASCII) characters. Ruby chooses the default encoding based on `LANG`. If `LANG=C`, Ruby uses the `US-ASCII` encoding as the default encoding. If Ruby uses the `US-ASCII` encoding, we can't process `KEYS` because it has non ASCII characters. ### What changes are included in this PR? Use the `UTF-8` encoding explicitly for `KEYS`. If we specify the `UTF-8` encoding explicitly, our `KEYS` processing don't depend on `LANG`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39074 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
KEYSmay have UTF-8 (non ASCII) characters. Ruby chooses the default encoding based onLANG. IfLANG=C, Ruby uses theUS-ASCIIencoding as the default encoding. If Ruby uses theUS-ASCIIencoding, we can't processKEYSbecause it has non ASCII characters.What changes are included in this PR?
Use the
UTF-8encoding explicitly forKEYS. If we specify theUTF-8encoding explicitly, ourKEYSprocessing don't depend onLANG.Are these changes tested?
Yes.
Are there any user-facing changes?
No.