New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39041:[R] Improve update-checksum.R
output
#39042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're the only person who is likely to see this output so I trust that the output is useful to you! I do think you want cat()
instead of print()
though (which will get rid of the extraneous [1]
prefixes in your output).
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 7346bdf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change The script was to quiet. ### What changes are included in this PR? Fix regex and add some output: ``` Rscript tools/update-checksums.R 14.0.0 1 ✘ [1] "Extracting libarrow binary paths from tasks.yml" [1] "Downloading windows/arrow-14.0.0.zip.sha512" [1] "Converting windows/arrow-14.0.0.zip to windows style line endings" [1] "Downloading linux-openssl-1.0/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Checksums updated successfully!" ``` ### Are these changes tested? locally ### Are there any user-facing changes? no * Closes: #39041 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change The script was to quiet. ### What changes are included in this PR? Fix regex and add some output: ``` Rscript tools/update-checksums.R 14.0.0 1 ✘ [1] "Extracting libarrow binary paths from tasks.yml" [1] "Downloading windows/arrow-14.0.0.zip.sha512" [1] "Converting windows/arrow-14.0.0.zip to windows style line endings" [1] "Downloading linux-openssl-1.0/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Checksums updated successfully!" ``` ### Are these changes tested? locally ### Are there any user-facing changes? no * Closes: apache#39041 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Rationale for this change
The script was to quiet.
What changes are included in this PR?
Fix regex and add some output:
Are these changes tested?
locally
Are there any user-facing changes?
no
update-checksums.R
#39041