Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39003: [CI][macOS] Don't update Homebrew #39016

Merged
merged 1 commit into from Dec 1, 2023
Merged

Conversation

kou
Copy link
Member

@kou kou commented Dec 1, 2023

Rationale for this change

It's better that we always use the latest Homebrew to check with the latest Homebrew that are used by most users. But it's difficult to maintain.

What changes are included in this PR?

We don't update Homebrew manually. GitHub hosted GitHub Actions Runners update Homebrew periodically. We depend on it instead of manual brew update.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

It's better that we always use the latest Homebrew to check with the
latest Homebrew that are used by most users. But it's difficult to
maintain. So we don't update Homebrew. GitHub hosted GitHub Actions
Runners updates Homebrew periodically. We depend on it.
Copy link

github-actions bot commented Dec 1, 2023

⚠️ GitHub issue #39003 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 1, 2023
@kou
Copy link
Member Author

kou commented Dec 1, 2023

@github-actions crossbow submit verify-rc-macos

Copy link

github-actions bot commented Dec 1, 2023

Revision: d7bf6d9

Submitted crossbow builds: ursacomputing/crossbow @ actions-598d7218c2

Task Status
verify-rc-binaries-wheels-macos-11-amd64 Github Actions
verify-rc-binaries-wheels-macos-11-arm64 Github Actions
verify-rc-binaries-wheels-macos-12-amd64 Github Actions
verify-rc-source-cpp-macos-amd64 Github Actions
verify-rc-source-cpp-macos-arm64 Github Actions
verify-rc-source-cpp-macos-conda-amd64 Github Actions
verify-rc-source-csharp-macos-amd64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions
verify-rc-source-go-macos-amd64 Github Actions
verify-rc-source-go-macos-arm64 Github Actions
verify-rc-source-integration-macos-amd64 Github Actions
verify-rc-source-integration-macos-arm64 Github Actions
verify-rc-source-integration-macos-conda-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions
verify-rc-source-js-macos-amd64 Github Actions
verify-rc-source-js-macos-arm64 Github Actions
verify-rc-source-python-macos-amd64 Github Actions
verify-rc-source-python-macos-arm64 Github Actions
verify-rc-source-python-macos-conda-amd64 Github Actions
verify-rc-source-ruby-macos-amd64 Github Actions
verify-rc-source-ruby-macos-arm64 Github Actions

@kou
Copy link
Member Author

kou commented Dec 1, 2023

+1

js and integration failures are unrelated: #39020

@kou kou merged commit 985e86a into apache:main Dec 1, 2023
22 of 23 checks passed
@kou kou deleted the ci-macos-homebrew branch December 1, 2023 01:52
@kou kou removed the awaiting committer review Awaiting committer review label Dec 1, 2023
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 985e86a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

raulcd pushed a commit that referenced this pull request Dec 6, 2023
### Rationale for this change

It's better that we always use the latest Homebrew to check with the latest Homebrew that are used by most users. But it's difficult to maintain.

### What changes are included in this PR?

We don't update Homebrew manually. GitHub hosted GitHub Actions Runners update Homebrew periodically. We depend on it instead of manual `brew update`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #39003

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

It's better that we always use the latest Homebrew to check with the latest Homebrew that are used by most users. But it's difficult to maintain.

### What changes are included in this PR?

We don't update Homebrew manually. GitHub hosted GitHub Actions Runners update Homebrew periodically. We depend on it instead of manual `brew update`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#39003

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] AMD64 macOS 12 Python 3 is failing on CI due to failing to upgrade c-ares from brew
1 participant