Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36928: [Java] Make it run well with the netty newest version 4.1.96 #36926

Merged
merged 1 commit into from Jul 28, 2023

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jul 28, 2023

When I used netty arrow memory 13.0.0 and netty 4.1.96.Final in Spark, the following error occurred,
Because netty 4.1.96.Final version has revert some modifications, in order to ensure that netty arrow memory 13.0.0 works well with netty 4.1.96.Final version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
image

2.Some modifications have been reverted in netty 4.1.96.Final as follows:
image
image
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@panbingkun
Copy link
Contributor Author

When I used netty arrow memory 13.0.0 and netty 4.1.96.Final in Spark, the following error occurred,
Because netty 4.1.96.Final version has revert some modifications, in order to ensure that netty arrow memory 13.0.0 works well with netty 4.1.96.Final version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
image

2.Some modifications have been reverted in netty 4.1.96.Final as follows:
image
image
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510

@panbingkun panbingkun changed the title Make it run well with the netty newest version 4.1.96 GH-36928: [Java] Make it run well with the netty newest version 4.1.96 Jul 28, 2023
@github-actions
Copy link

⚠️ GitHub issue #36928 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@raulcd since we don't have RC2 out yet, would it be possible to cherry-pick this too? It also apparently avoids a potential performance regression in Flight

@raulcd
Copy link
Member

raulcd commented Jul 28, 2023

Sure! that sounds good to me!

@lidavidm lidavidm merged commit 6b1c723 into apache:main Jul 28, 2023
16 of 17 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jul 28, 2023
@lidavidm
Copy link
Member

Thanks Raúl! I added this to the 13.0.0 milestone, I'll go update the blog post too

@raulcd
Copy link
Member

raulcd commented Jul 28, 2023

I added this to the 13.0.0 milestone

cherry-picked to maint-13.0.0

raulcd pushed a commit that referenced this pull request Jul 28, 2023
#36926)

When I used `netty arrow memory 13.0.0` and `netty 4.1.96.Final` in Spark, the following error occurred,
Because `netty 4.1.96.Final` version has revert some modifications, in order to ensure that `netty arrow memory 13.0.0` works well with ``netty 4.1.96.Final`` version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
<img width="955" alt="image" src="https://github.com/apache/arrow/assets/15246973/e7ee2da9-97c0-474c-a62d-5821858e361f">

2.Some modifications have been reverted in `netty 4.1.96.Final` as follows:
<img width="884" alt="image" src="https://github.com/apache/arrow/assets/15246973/0226685a-cfa3-4b8b-b114-23ad8d027c05">
<img width="907" alt="image" src="https://github.com/apache/arrow/assets/15246973/a6ea21a0-8531-42b6-ab9d-25eaab1c7fde">
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510
* Closes: #36928

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member

@github-actions crossbow submit spark

@github-actions
Copy link

Revision: 3006cfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-1f081194d6

Task Status
test-conda-python-3.10-spark-master Github Actions
test-conda-python-3.8-spark-v3.1.2 Github Actions
test-conda-python-3.9-spark-v3.2.0 Github Actions

xxlaykxx added a commit to dremio/arrow that referenced this pull request Jul 30, 2023
… 4.1.96 (apache#36926) (#40)

When I used `netty arrow memory 13.0.0` and `netty 4.1.96.Final` in Spark, the following error occurred,
Because `netty 4.1.96.Final` version has revert some modifications, in order to ensure that `netty arrow memory 13.0.0` works well with ``netty 4.1.96.Final`` version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
<img width="955" alt="image" src="https://github.com/apache/arrow/assets/15246973/e7ee2da9-97c0-474c-a62d-5821858e361f">

2.Some modifications have been reverted in `netty 4.1.96.Final` as follows:
<img width="884" alt="image" src="https://github.com/apache/arrow/assets/15246973/0226685a-cfa3-4b8b-b114-23ad8d027c05">
<img width="907" alt="image" src="https://github.com/apache/arrow/assets/15246973/a6ea21a0-8531-42b6-ab9d-25eaab1c7fde">
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510
* Closes: apache#36928

Authored-by: panbingkun <pbk1982@gmail.com>

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: panbingkun <84731559@qq.com>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6b1c723.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
… 4.1.96 (apache#36926)

When I used `netty arrow memory 13.0.0` and `netty 4.1.96.Final` in Spark, the following error occurred,
Because `netty 4.1.96.Final` version has revert some modifications, in order to ensure that `netty arrow memory 13.0.0` works well with ``netty 4.1.96.Final`` version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
<img width="955" alt="image" src="https://github.com/apache/arrow/assets/15246973/e7ee2da9-97c0-474c-a62d-5821858e361f">

2.Some modifications have been reverted in `netty 4.1.96.Final` as follows:
<img width="884" alt="image" src="https://github.com/apache/arrow/assets/15246973/0226685a-cfa3-4b8b-b114-23ad8d027c05">
<img width="907" alt="image" src="https://github.com/apache/arrow/assets/15246973/a6ea21a0-8531-42b6-ab9d-25eaab1c7fde">
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510
* Closes: apache#36928

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
… 4.1.96 (apache#36926)

When I used `netty arrow memory 13.0.0` and `netty 4.1.96.Final` in Spark, the following error occurred,
Because `netty 4.1.96.Final` version has revert some modifications, in order to ensure that `netty arrow memory 13.0.0` works well with ``netty 4.1.96.Final`` version, I suggest making similar modifications here.
1.Compilation errors are as follows:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/47657403
<img width="955" alt="image" src="https://github.com/apache/arrow/assets/15246973/e7ee2da9-97c0-474c-a62d-5821858e361f">

2.Some modifications have been reverted in `netty 4.1.96.Final` as follows:
<img width="884" alt="image" src="https://github.com/apache/arrow/assets/15246973/0226685a-cfa3-4b8b-b114-23ad8d027c05">
<img width="907" alt="image" src="https://github.com/apache/arrow/assets/15246973/a6ea21a0-8531-42b6-ab9d-25eaab1c7fde">
https://netty.io/news/2023/07/27/4-1-96-Final.html
netty/netty#13510
* Closes: apache#36928

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Make it run well with the netty newest version 4.1.96
3 participants