Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] ConcatenateBuffers triggers a UBSan error when called with an empty buffer #36913

Closed
sfc-gh-ebrossard opened this issue Jul 27, 2023 · 0 comments · Fixed by #36914
Closed

[C++] ConcatenateBuffers triggers a UBSan error when called with an empty buffer #36913

sfc-gh-ebrossard opened this issue Jul 27, 2023 · 0 comments · Fixed by #36914
Assignees
@sfc-gh-ebrossard
Labels
Component: C++ Type: bug
Milestone
13.0.0

Comments

@sfc-gh-ebrossard
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

If buffer->data() is nullptr here, ConcatenateBuffers calls std::memcpy with nullptr for the src argument, which is undefined behavior:

If either dest or src is an invalid or null pointer, the behavior is undefined, even if count is zero.

The simplest fix is probably to skip the std::memcpy call if the buffer has zero length.

Component(s)

C++
sfc-gh-ebrossard added a commit to sfc-gh-ebrossard/arrow that referenced this issue Jul 27, 2023
@sfc-gh-ebrossard
apacheGH-36913: [C++] Skip empty buffer concatenation to fix UBSan error
6d25184
@ianmcook ianmcook changed the title ConcatenateBuffers triggers a UBSan error when called with an empty buffer [C++] ConcatenateBuffers triggers a UBSan error when called with an empty buffer Jul 27, 2023
@github-actions github-actions bot mentioned this issue Jul 27, 2023
Merged
@pitrou pitrou added this to the 14.0.0 milestone Jul 27, 2023
pitrou added a commit that referenced this issue Jul 27, 2023
@sfc-gh-ebrossard @pitrou
GH-36913: [C++] Skip empty buffer concatenation to fix UBSan error (#…
bedc1e7 
…36914)

### Rationale for this change

This is a trivial fix for a UBSan error in calls to `ConcatenateBuffers` with an empty buffer that has a null data pointer.

### What changes are included in this PR?

Conditional call to `std::memcpy` based on whether the buffer's length is 0.

### Are these changes tested?

Test added in buffer_test.cc.

### Are there any user-facing changes?

No
* Closes: #36913

Lead-authored-by: Elliott Brossard <elliott.brossard@snowflake.com>
Co-authored-by: Elliott Brossard <64754120+sfc-gh-ebrossard@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcd raulcd modified the milestones: 14.0.0, 13.0.0 Jul 28, 2023
raulcd pushed a commit that referenced this issue Jul 28, 2023
@sfc-gh-ebrossard @pitrou @raulcd
GH-36913: [C++] Skip empty buffer concatenation to fix UBSan error (#…
4d22851 
…36914)

### Rationale for this change

This is a trivial fix for a UBSan error in calls to `ConcatenateBuffers` with an empty buffer that has a null data pointer.

### What changes are included in this PR?

Conditional call to `std::memcpy` based on whether the buffer's length is 0.

### Are these changes tested?

Test added in buffer_test.cc.

### Are there any user-facing changes?

No
* Closes: #36913

Lead-authored-by: Elliott Brossard <elliott.brossard@snowflake.com>
Co-authored-by: Elliott Brossard <64754120+sfc-gh-ebrossard@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@sfc-gh-ebrossard @pitrou @R-JunmingChen
apacheGH-36913: [C++] Skip empty buffer concatenation to fix UBSan er…
aaef24a 
…ror (apache#36914)

### Rationale for this change

This is a trivial fix for a UBSan error in calls to `ConcatenateBuffers` with an empty buffer that has a null data pointer.

### What changes are included in this PR?

Conditional call to `std::memcpy` based on whether the buffer's length is 0.

### Are these changes tested?

Test added in buffer_test.cc.

### Are there any user-facing changes?

No
* Closes: apache#36913

Lead-authored-by: Elliott Brossard <elliott.brossard@snowflake.com>
Co-authored-by: Elliott Brossard <64754120+sfc-gh-ebrossard@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@sfc-gh-ebrossard @pitrou @loicalleyne
apacheGH-36913: [C++] Skip empty buffer concatenation to fix UBSan er…
963ad48 
…ror (apache#36914)

### Rationale for this change

This is a trivial fix for a UBSan error in calls to `ConcatenateBuffers` with an empty buffer that has a null data pointer.

### What changes are included in this PR?

Conditional call to `std::memcpy` based on whether the buffer's length is 0.

### Are these changes tested?

Test added in buffer_test.cc.

### Are there any user-facing changes?

No
* Closes: apache#36913

Lead-authored-by: Elliott Brossard <elliott.brossard@snowflake.com>
Co-authored-by: Elliott Brossard <64754120+sfc-gh-ebrossard@users.noreply.github.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-ebrossard sfc-gh-ebrossard

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36913: [C++] Skip empty buffer concatenation to fix UBSan error sfc-gh-ebrossard/arrow
3 participants
@raulcd @pitrou @sfc-gh-ebrossard