Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] C Data Interface: export a dummy non-null buffer for null/0-size buffers #33936

Closed
lidavidm opened this issue Jan 30, 2023 · 0 comments · Fixed by #33951
Closed

[Go] C Data Interface: export a dummy non-null buffer for null/0-size buffers #33936

lidavidm opened this issue Jan 30, 2023 · 0 comments · Fixed by #33951
Assignees
@lidavidm
Labels
Component: Go Type: enhancement
Milestone
12.0.0

Comments

@lidavidm
Copy link
Member

Describe the enhancement requested

Related to #14875, #14805.

Go exports a NULL buffer if the source buffer is either nil or 0-sized. While technically this is valid by #14805, libarrow < 12 doesn't handle it, and it would be easiest just to export a dummy buffer (ideally a static global) to make interoperability easier.

Component(s)

Go
@lidavidm lidavidm self-assigned this Jan 30, 2023
lidavidm added a commit to lidavidm/arrow that referenced this issue Jan 31, 2023
@lidavidm
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
a08fc55 
…ffers
@github-actions github-actions bot mentioned this issue Jan 31, 2023
Merged
lidavidm added a commit to lidavidm/arrow that referenced this issue Jan 31, 2023
@lidavidm
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
ae7f2d0 
…ffers
lidavidm added a commit to lidavidm/arrow that referenced this issue Jan 31, 2023
@lidavidm
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
245f751 
…ffers
lidavidm added a commit that referenced this issue Jan 31, 2023
@lidavidm
GH-33936: [Go] C Data Interface: export dummy buffer for nil buffers (#…
5765aa2 
…33951)

### Rationale for this change

While #14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: #33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 12.0.0 milestone Jan 31, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@lidavidm @sjperkins
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
843c18f 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@lidavidm
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
da86dc7 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@lidavidm @fatemehp
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
d14ca4b 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33936: [Go] C Data Interface: export dummy buffer for nil buffers lidavidm/arrow
1 participant
@lidavidm