Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++][Java] Gandiva tests cause java-jars nightly to fail #25633

Closed
assignUser opened this issue Jan 10, 2023 · 7 comments · Fixed by #33711
Closed

[CI][C++][Java] Gandiva tests cause java-jars nightly to fail #25633

assignUser opened this issue Jan 10, 2023 · 7 comments · Fixed by #33711

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/3881589871/jobs/6620764549#step:6:2862

The following tests FAILED:
	 30 - arrow-compute-scalar-test (Failed)
	 64 - gandiva-internals-test (Failed)
	 66 - gandiva-filter-test (Failed)
	 67 - gandiva-projector-test (Failed)
	 68 - gandiva-projector-build-validation-test (Failed)
	 69 - gandiva-if-expr-test (Failed)
	 70 - gandiva-literal-test (Failed)
	 71 - gandiva-boolean-expr-test (Failed)
	 72 - gandiva-binary-test (Failed)
	 73 - gandiva-date-time-test (Failed)
	 74 - gandiva-to-string-test (Failed)
	 75 - gandiva-utf8-test (Failed)
	 76 - gandiva-hash-test (Failed)
	 77 - gandiva-in-expr-test (Failed)
	 78 - gandiva-null-validity-test (Failed)
	 79 - gandiva-decimal-test (Failed)
	 80 - gandiva-decimal-single-test (Failed)
	 81 - gandiva-filter-project-test (Failed)
	 82 - gandiva-projector-test-static (Failed)

Component(s)

C++ - Gandiva, Continuous Integration, Java

@assignUser
Copy link
Member Author

I added the blocker label as this prevents production of the java jars

@felipecrv
Copy link
Contributor

felipecrv commented Jan 10, 2023

The log shows lots of linker errors warnings that only happen in the macOS ARM build. I have a M1 Mac and could look into this tomorrow. It's late here and I haven't set up the Arrow build in the Mac yet.

@js8544
Copy link
Collaborator

js8544 commented Jan 11, 2023

The problem seems to be with the RE2 library. All tests cases that segfaulted use the RE2 library to do regex matching, namely:
arrow-compute-scalar-test: TestBaseBinaryKernels/0.FindSubstringIgnoreCase
gandiva-internals-test: TestLikeHolder.TestMatchAny
gandiva-filter-test: TestFilter.TestLike
gandiva-utf8-test: TestUtf8.TestLike
gandiva-projector-test: TestProjector.TestRegexpExtract
gandiva-projector-test-static: TestProjector.TestRegexpExtract

@js8544
Copy link
Collaborator

js8544 commented Jan 11, 2023

java-jars has been failing with this error since 2022-12-27: https://github.com/ursacomputing/crossbow/actions/runs/3786202064/jobs/6437491716 on commit 9ac4259. On 12-26 it was successful: https://github.com/ursacomputing/crossbow/actions/runs/3780146447/jobs/6425989756 on commit 9b22860. The difference between the two runs are these four commits: be96d20, 130f41a, 43b95e6, 9ac4259. The diff can be seen here: https://github.com/apache/arrow/compare/9b228600..9ac42594

@felipecrv
Copy link
Contributor

Unfortunately I'm unable to reproduce the issue on my M1 Mac. The gandiva tests run successfully on my machine.

@kou
Copy link
Member

kou commented Jan 12, 2023

@assignUser Can we ssh to the self-hosted runner for https://github.com/ursacomputing/crossbow/actions/runs/3786202064/jobs/6436882897 to debug this?

@raulcd raulcd added this to the 11.0.0 milestone Jan 16, 2023
@raulcd
Copy link
Member

raulcd commented Jan 16, 2023

this is the last success build (26th of December) prior to the initial failure: https://github.com/ursacomputing/crossbow/actions/runs/3780146447/jobs/6425989756
In case any difference on the logs can help

kou added a commit to kou/arrow that referenced this issue Jan 17, 2023
If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and
bundled RE2. If we mix re2.h and libre2.a, we may generate wrong
re2::RE2::Options. It may crashes our program.
assignUser pushed a commit that referenced this issue Jan 17, 2023
### Rationale for this change

If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and bundled RE2.
If we mix re2.h and libre2.a, we may generate wrong re2::RE2::Options. It may crashes our program.

### What changes are included in this PR?

Ensure removing Homebrew's RE2.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #25633

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd pushed a commit that referenced this issue Jan 18, 2023
### Rationale for this change

If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and bundled RE2.
If we mix re2.h and libre2.a, we may generate wrong re2::RE2::Options. It may crashes our program.

### What changes are included in this PR?

Ensure removing Homebrew's RE2.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #25633

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants