From 057f291eff7a7a52cbc58ee08a23e47e9460e47d Mon Sep 17 00:00:00 2001 From: Nic Crane Date: Tue, 17 Jan 2023 02:45:57 +0000 Subject: [PATCH] GH-33666: [R] Remove extraneous argument to semi_join (#33693) This PR removes the `keep` argument from the test for `semi_join()`, which are causing the unit tests to fail. It also removes the argument `suffix` argument (which is not part of the dplyr function signature) from the function signature here. Closes: #33666 Authored-by: Nic Crane Signed-off-by: Dewey Dunnington --- r/tests/testthat/test-dplyr-join.R | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/r/tests/testthat/test-dplyr-join.R b/r/tests/testthat/test-dplyr-join.R index 3470a886b3834..2520d561cfd1b 100644 --- a/r/tests/testthat/test-dplyr-join.R +++ b/r/tests/testthat/test-dplyr-join.R @@ -82,7 +82,7 @@ test_that("left_join with join_by", { left_join( to_join %>% rename(the_grouping = some_grouping), - join_by(some_grouping == the_grouping) + join_by(some_grouping == the_grouping) ) %>% collect(), left @@ -240,14 +240,7 @@ test_that("full_join", { test_that("semi_join", { compare_dplyr_binding( .input %>% - semi_join(to_join, by = "some_grouping", keep = TRUE) %>% - collect(), - left - ) - - compare_dplyr_binding( - .input %>% - semi_join(to_join, by = "some_grouping", keep = FALSE) %>% + semi_join(to_join, by = "some_grouping") %>% collect(), left )