Print container logs in CI #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jan 5, 2024
| @@ -121,10 +121,12 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
|
|
|||
| # We are forced to use docker commands instead of service containers as we need to override the entrypoints | |||
There was a problem hiding this comment.
Their reticence to add support for this would suggest the runner is talking to the docker daemon using the CLI instead of the gRPC API, which is kind of terrifying
tustvold
force-pushed
the
print-logs-containers-ci
branch
from
fe3065f
to
7360913
Compare
tustvold
force-pushed
the
print-logs-containers-ci
branch
from
7360913
to
cb5ae2e
Compare
tustvold
force-pushed
the
print-logs-containers-ci
branch
from
cb5ae2e
to
87681cd
Compare
|
This only impacts CI and is non-controversial so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5283
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?