Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regexp_match take scalar pattern and flag #5246

Closed
viirya opened this issue Dec 26, 2023 · 1 comment · Fixed by #5245
Closed

Make regexp_match take scalar pattern and flag #5246

viirya opened this issue Dec 26, 2023 · 1 comment · Fixed by #5245
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Dec 26, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

regexp_match kernel currently assumes patterns and flags are all arrays with same length as string array. For the kernel, one usual case is to use scalar pattern and flag, we don't need to build pattern hash map.

Describe the solution you'd like

Make regexp_match kernel take scalar pattern and flag

Describe alternatives you've considered

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Dec 26, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Jan 5, 2024
@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'arrow'} from #5245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants