Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet: read parquet metadata with page index in async and with size hints #5129

Closed
AdamGS opened this issue Nov 27, 2023 · 3 comments · Fixed by #5137
Closed

Parquet: read parquet metadata with page index in async and with size hints #5129

AdamGS opened this issue Nov 27, 2023 · 3 comments · Fixed by #5137
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@AdamGS
Copy link
Contributor

AdamGS commented Nov 27, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We have multiple cases where we want to just load parquet file metadata with the page index, we already have metadata and file sizes stored externally but there doesn't seem to be a way to read that data without using object_store.
fetch_parquet_metadata doesn't load the page index and but does use hints, and ArrowReaderMetadata doesn't use hints and forces us to jump through hoops and have an additional implementation of AsyncFileReader.

Describe the solution you'd like

I think that adding an argument to fetch_parquet_metadata is easier than stabilizing MetadataLoader, and will work with many other readers that can read byte ranges.

Describe alternatives you've considered

We currently just maintain a minor fork with MetadataLoader and MetadataFetch made public.

Will be glad to do any and all work required here (either adding an argument to fetch_parquet_metadata, helping stabilize MetadataLoader or anything else), but I would like to make sure I'm doing something that's actually valuable and not just spamming the maintainers here.

@AdamGS AdamGS added the enhancement Any new improvement worthy of a entry in the changelog label Nov 27, 2023
@tustvold
Copy link
Contributor

I don't see a compelling reason not to make MetadataLoader public and would be happy to review a PR doing so, the API seems unlikely to change in the near future

@AdamGS
Copy link
Contributor Author

AdamGS commented Nov 28, 2023

Awesome! I'll hopefully have a PR ready today.

@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'parquet'} from #5137

@tustvold tustvold added the parquet Changes to the parquet crate label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants