Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet: derive boundary order when writing columns #5074

Closed
Jefffrey opened this issue Nov 14, 2023 · 2 comments · Fixed by #5110
Closed

Parquet: derive boundary order when writing columns #5074

Jefffrey opened this issue Nov 14, 2023 · 2 comments · Fixed by #5110
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented Nov 14, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

See

// TODO: calc the order for all pages in this column
boundary_order: BoundaryOrder,

From parquet thrift:

https://github.com/apache/parquet-format/blob/46cc3a0647d301bb9579ca8dd2cc356caf2a72d2/src/main/thrift/parquet.thrift#L982-L988

  /**
   * Stores whether both min_values and max_values are ordered and if so, in
   * which direction. This allows readers to perform binary searches in both
   * lists. Readers cannot assume that max_values[i] <= min_values[i+1], even
   * if the lists are ordered.
   */
  4: required BoundaryOrder boundary_order

Describe the solution you'd like

Be able to set this boundary order when writing parquet files

Describe alternatives you've considered

Additional context

Some additional reading/discussion;

https://github.com/apache/parquet-format/blob/master/PageIndex.md

#5003 (comment)

  • Need to ensure for special types like Float16 where sort order differs from its physical type representation that this is accounted for & tested
@Jefffrey Jefffrey added the enhancement Any new improvement worthy of a entry in the changelog label Nov 14, 2023
@Jefffrey
Copy link
Contributor Author

Planning to take a shot at this

@tustvold tustvold added the parquet Changes to the parquet crate label Jan 5, 2024
@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'parquet'} from #5110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants