Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/Max Kernels Should Use Total Ordering #5031

Closed
tustvold opened this issue Nov 2, 2023 · 1 comment · Fixed by #5100
Closed

Min/Max Kernels Should Use Total Ordering #5031

tustvold opened this issue Nov 2, 2023 · 1 comment · Fixed by #5100
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We have gradually converged on using total ordering everywhere, as opposed to special casing NaN for floating point numbers. It would appear that the min and max kernels have not yet been updated.

Describe the solution you'd like

We should update the min and max kernels to use total ordering.

Describe alternatives you've considered

Additional context

apache/datafusion#8031 is an upstream report of this issue

#5032 may be related to making the aggregate kernels use total ordering

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Nov 2, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Jan 5, 2024
@tustvold
Copy link
Contributor Author

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'arrow'} from #5100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant