Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add cmake-format to pre-commit #520

Closed
kou opened this issue Jan 15, 2025 · 0 comments · Fixed by #521
Closed

[CI] Add cmake-format to pre-commit #520

kou opened this issue Jan 15, 2025 · 0 comments · Fixed by #521
Labels
Type: enhancement New feature or request
Milestone
18.2.0

Comments

@kou
Copy link
Member

kou commented Jan 15, 2025

Describe the enhancement requested

We can use https://github.com/cheshirekow/cmake-format-precommit .

But it seems that cmake-format isn't maintained...
@kou kou added the Type: enhancement New feature or request label Jan 15, 2025
kou added a commit to kou/arrow-java that referenced this issue Jan 15, 2025
@kou
apacheGH-520: [CI] Add cmake-format to pre-commit
Loading
Loading status checks…
2517d6d 
Fixes apacheGH-520.

The configuration file is borrowed from apache/arrow.
@kou kou mentioned this issue Jan 15, 2025
Merged
kou added a commit that referenced this issue Jan 15, 2025
@kou
GH-520: [CI] Add cmake-format to pre-commit (#521)
Loading
Loading status checks…
89217c8 
Fixes GH-520.

The configuration file is borrowed from apache/arrow.
@kou kou closed this as completed in #521 Jan 15, 2025
@lidavidm lidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
18.2.0
Development

Successfully merging a pull request may close this issue.

GH-520: [CI] Add cmake-format to pre-commit kou/arrow-java
2 participants
@kou @lidavidm