Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrowReader instead of ArrowStreamReader in FlightSqlClient.executeIngest method #483

Closed
eramitmittal opened this issue Jan 6, 2025 · 1 comment
Closed

Use ArrowReader instead of ArrowStreamReader in FlightSqlClient.executeIngest method #483

eramitmittal opened this issue Jan 6, 2025 · 1 comment
Labels
Type: enhancement New feature or request
Milestone
18.2.0

Comments

@eramitmittal
Copy link
Contributor

Describe the enhancement requested

Currently FlightSqlClient.executeIngest(final ArrowStreamReader dataReader, ...) accepts an ArrowStreamReader which is a subclass of ArrowReader. This is an oversight as really what we need is ArrowReader to allow passing any kind of Arrow Reader.
@eramitmittal eramitmittal added the Type: enhancement New feature or request label Jan 6, 2025
eramitmittal added a commit to eramitmittal/arrow-java that referenced this issue Jan 6, 2025
@eramitmittal
apacheGH-483: Use ArrowReader instead of ArrowStreamReader in FlightS…
c724b1e 
…qlClient.executeIngest method
@eramitmittal eramitmittal mentioned this issue Jan 6, 2025
Closed
eramitmittal added a commit to eramitmittal/arrow-java that referenced this issue Jan 6, 2025
@eramitmittal
apacheGH-483: Use ArrowReader instead of ArrowStreamReader in FlightS…
d6df3c2 
…qlClient.executeIngest method
@eramitmittal eramitmittal mentioned this issue Jan 6, 2025
Merged
lidavidm pushed a commit that referenced this issue Jan 8, 2025
@eramitmittal
GH-483: Use ArrowReader instead of ArrowStreamReader in FlightSqlClie…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2f6e245 
…nt.executeIngest method (#485)

Please see #483
@eramitmittal
Copy link
Contributor Author

merged, closing

@lidavidm lidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
18.2.0
Development

No branches or pull requests
2 participants
@lidavidm @eramitmittal