fix(pqarrow): respect list element nullability during conversion #311
+27
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While working on iceberg-go I discovered a bug in how we converted Arrow <--> Parquet schemas when dealing with the nullability of the element for a list field.
What changes are included in this PR?
Fixing the proper handling for nullability instead of blanket setting it to nullable for elements of lists. Thus correctly propagating the nullability.
Are these changes tested?
Yes, unit tests are added.
Are there any user-facing changes?
Parquet schemas that are being created from Arrow Schemas will now properly respect the required/optional for elements of lists.