feat(parquet): add byte buffer when disable buffered stream

[joechenrh]

Rationale for this change

When we create a reader with BufferedStreamEnabled = false, we have to first create a data slice.

arrow-go/parquet/reader_properties.go

Lines 76 to 91 in efecae3

	func (r *ReaderProperties) GetStream(source io.ReaderAt, start, nbytes int64) (BufferedReader, error) {
	if r.BufferedStreamEnabled {
	return utils.NewBufferedReader(io.NewSectionReader(source, start, nbytes), int(r.BufferSize)), nil
	}
	data := make([]byte, nbytes)
	n, err := source.ReadAt(data, start)
	if err != nil {
	return nil, fmt.Errorf("parquet: tried reading from file, but got error: %w", err)
	}
	if n != int(nbytes) {
	return nil, fmt.Errorf("parquet: tried reading %d bytes starting at position %d from file but only got %d", nbytes, start, n)
	}
	return utils.NewBufferedReader(bytes.NewReader(data), int(nbytes)), nil
	}

And we will create another slice with same size in the NewBufferedReader again, which is redundant.

arrow-go/internal/utils/buf_reader.go

Lines 45 to 51 in efecae3

	func NewBufferedReader(rd Reader, sz int) *bufferedReader {
	r := &bufferedReader{
	rd: rd,
	}
	r.resizeBuffer(sz)
	return r
	}

What changes are included in this PR?

• Add a new struct byteReader, which is a wrapper of bytes.NewReader and implement BufferedReader interface.
• Remove BufferSize() method from BufferedReader interface

Are these changes tested?

BufferedReader created from bytes.NewReader in tests are all replaced by new function NewByteReader.

Are there any user-facing changes?

No.

[zeroshade]

This would remove our respecting of the BufferSize property in the reader properties, we shouldn't be removing the BufferSize() method

[joechenrh]

So how about change it to:

readBufSize := min(p.dataOffset-p.baseOffset, p.r.BufferSize())
rd := utils.NewBufferedReader(
	io.NewSectionReader(p.r.Outer(), p.dictOffset-p.baseOffset, p.dataOffset-p.baseOffset),
	readBufSize)

[zeroshade]

that works

[joechenrh]

Can I manually rerun the CI?

[kou]

Done!

[zeroshade]

Thanks!