Backport to 37: group by count distinct doesn't work for timestamps with time zone #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix DistinctCount for timestamps with time zone Preserve the original data type in the aggregation state * Add tests for decimal count distinct
10 tasks
|
@andygrove do you happen to have time to review / approve this PR for the 37.1.0 release? |
viirya
approved these changes
Apr 17, 2024
viirya
reviewed
Apr 17, 2024
| } | ||
| dt @ Timestamp(Microsecond, _) => Box::new( | ||
| PrimitiveDistinctCountAccumulator::<TimestampMicrosecondType>::new() | ||
| .with_data_type(dt.clone()), |
|
FYI @joroKr21 and @thinkharderdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note this targets
branch-37, NOTmain)Which issue does this PR close?
Part of 37 maintenance release #9904
Rationale for this change
Backport fixes for regressions
What changes are included in this PR?
Backport #10042, fix for #10043 to
branch-37Are these changes tested?
tests are included in backport