From e2b79fedffe52d0e051648a1f916ebd58f1f9e49 Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Fri, 25 Aug 2023 00:01:42 -0500 Subject: [PATCH 1/4] fix: add new error expiration as part of endpoints information --- java/source/flight.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/java/source/flight.rst b/java/source/flight.rst index 53017b24..fba29e71 100644 --- a/java/source/flight.rst +++ b/java/source/flight.rst @@ -287,7 +287,7 @@ Flight Client and Server S1: Server (Location): Listening on port 33333 C1: Client (Location): Connected to grpc+tcp://0.0.0.0:33333 C2: Client (Populate Data): Wrote 2 batches with 3 rows each - C3: Client (Get Metadata): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a}], bytes=-1, records=6, ordered=false} + C3: Client (Get Metadata): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a, expirationTime=(none)}], bytes=-1, records=6, ordered=false} C4: Client (Get Stream): Client Received batch #1, Data: name @@ -299,7 +299,7 @@ Flight Client and Server Manuel Felipe JJ - C5: Client (List Flights Info): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a}], bytes=-1, records=6, ordered=false} + C5: Client (List Flights Info): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a, expirationTime=(none)}], bytes=-1, records=6, ordered=false} C6: Client (Do Delete Action): Delete completed C7: Client (List Flights Info): After delete - No records C8: Server shut down successfully @@ -421,7 +421,7 @@ Once we do so, we can retrieve the metadata for that dataset. .. code-block:: shell - C3: Client (Get Metadata): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a}], bytes=-1, records=6} + C3: Client (Get Metadata): FlightInfo{schema=Schema, descriptor=profiles, endpoints=[FlightEndpoint{locations=[Location{uri=grpc+tcp://0.0.0.0:33333}], ticket=org.apache.arrow.flight.Ticket@58871b0a, expirationTime=(none)}], bytes=-1, records=6} Get Data ******** From 6b75557a58e8cc8fbcb89b941ba28de6381dfd7a Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Fri, 25 Aug 2023 00:23:04 -0500 Subject: [PATCH 2/4] fix AttributeError: No such config value: doctest_show_successes --- java/ext/javadoctest.py | 1 + 1 file changed, 1 insertion(+) diff --git a/java/ext/javadoctest.py b/java/ext/javadoctest.py index 7a53d39e..7cce5dea 100644 --- a/java/ext/javadoctest.py +++ b/java/ext/javadoctest.py @@ -105,6 +105,7 @@ def setup(app) -> Dict[str, Any]: app.add_directive("testoutput", TestoutputDirective) app.add_builder(JavaDocTestBuilder) # this config value adds to sys.path + app.add_config_value('doctest_show_successes', True, False) app.add_config_value("doctest_path", [], False) app.add_config_value("doctest_test_doctest_blocks", "default", False) app.add_config_value("doctest_global_setup", "", False) From 575bb334628eddaed5d41db35f63d42e0067e4e5 Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Fri, 25 Aug 2023 00:29:05 -0500 Subject: [PATCH 3/4] fix: clean code --- java/ext/javadoctest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/ext/javadoctest.py b/java/ext/javadoctest.py index 7cce5dea..20fc4c26 100644 --- a/java/ext/javadoctest.py +++ b/java/ext/javadoctest.py @@ -105,7 +105,7 @@ def setup(app) -> Dict[str, Any]: app.add_directive("testoutput", TestoutputDirective) app.add_builder(JavaDocTestBuilder) # this config value adds to sys.path - app.add_config_value('doctest_show_successes', True, False) + app.add_config_value("doctest_show_successes", True, False) app.add_config_value("doctest_path", [], False) app.add_config_value("doctest_test_doctest_blocks", "default", False) app.add_config_value("doctest_global_setup", "", False) From bc8a8a40511009cb5b3340d074a4be5194924c47 Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Fri, 25 Aug 2023 09:22:28 -0500 Subject: [PATCH 4/4] fix: comments code --- java/ext/javadoctest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/ext/javadoctest.py b/java/ext/javadoctest.py index 20fc4c26..ae109308 100644 --- a/java/ext/javadoctest.py +++ b/java/ext/javadoctest.py @@ -104,8 +104,8 @@ def setup(app) -> Dict[str, Any]: app.add_directive("testcode", JavaTestcodeDirective) app.add_directive("testoutput", TestoutputDirective) app.add_builder(JavaDocTestBuilder) - # this config value adds to sys.path app.add_config_value("doctest_show_successes", True, False) + # this config value adds to sys.path app.add_config_value("doctest_path", [], False) app.add_config_value("doctest_test_doctest_blocks", "default", False) app.add_config_value("doctest_global_setup", "", False)