Skip to content

Conversation

howardyoo
Copy link
Contributor

@howardyoo howardyoo commented Sep 23, 2024

Overview

Fixes: #42424
Fixes: #42425
which covers:

  • adding 'host.name' in the resource attributes to have metrics data contain minimum source information
  • adding support for OTEL_RESOURCE_ATTRIBUTES env variable for metrics

Please refer to the above github issues for more information regarding this PR. This PR is also intend to align the feature of OTEL metrics to that of the OTEL traces where the above feature is currently available, and thus beneficial for the metrics to have the same level of support.

Verified

This commit was signed with the committer’s verified signature.
djaglowski Daniel Jaglowski
@eladkal eladkal changed the title Support of host.name in OTEL metrics and usage of OTEL_RESOURCE_ATTRIBUTES in metrics(fixes: 42425, and 42424) Support of host.name in OTEL metrics and usage of OTEL_RESOURCE_ATTRIBUTES in metrics Sep 24, 2024
howardyoo and others added 2 commits September 29, 2024 09:13

Verified

This commit was signed with the committer’s verified signature.
djaglowski Daniel Jaglowski

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@potiuk potiuk merged commit db06cb8 into apache:main Oct 1, 2024
52 checks passed
@potiuk potiuk added this to the Airflow 2.10.3 milestone Oct 1, 2024
potiuk pushed a commit to potiuk/airflow that referenced this pull request Oct 1, 2024

Verified

This commit was signed with the committer’s verified signature.
dmathieu Damien Mathieu
…BUTES in metrics (apache#42428)

* fixes: 42425, and 42424

* fixed static type check failure

(cherry picked from commit db06cb8)
@howardyoo howardyoo deleted the howardyoo/42424 branch October 1, 2024 12:56
romsharon98 pushed a commit that referenced this pull request Oct 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…BUTES in metrics (#42428) (#42604)

* fixes: 42425, and 42424

* fixed static type check failure

(cherry picked from commit db06cb8)

Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com>
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
…BUTES in metrics (apache#42428)

* fixes: 42425, and 42424

* fixed static type check failure
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…BUTES in metrics (#42428) (#42604)

* fixes: 42425, and 42424

* fixed static type check failure

(cherry picked from commit db06cb8)

Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…BUTES in metrics (#42428) (#42604)

* fixes: 42425, and 42424

* fixed static type check failure

(cherry picked from commit db06cb8)

Co-authored-by: Howard Yoo <32691630+howardyoo@users.noreply.github.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024

Verified

This commit was signed with the committer’s verified signature.
jackgopack4 John L. Peterson (Jack)
…BUTES in metrics (apache#42428)

* fixes: 42425, and 42424

* fixed static type check failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of host.name in OTEL metrics Support of ResourceAttributes and for OTEL metrics
4 participants