-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update-constraints command that allows to modify released ones #33144
Conversation
e27d7cf
to
6905a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive PR! Few comments.
dev/breeze/src/airflow_breeze/commands/release_management_commands.py
Outdated
Show resolved
Hide resolved
6481d43
to
6056bdd
Compare
When applying comments from @amoghrajesh I found out that the docs (especially the dev/MANUALLY...) could benefit from some consistency and similar structure for the different "manual" parts. On one hand, it is unrelated change, on the other it's just updating the docs structure and content of a doc file tha we move and modify heavily so I went ahead and updated few more things in the same docs:
|
:D looking for some more reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good now!
Few nits which you can choose to ignore, @potiuk
6056bdd
to
5b6e791
Compare
Applied second round of comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit. Feel free to ignore
99cf1a4
to
c8b043b
Compare
Breeze PR looks for approval :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please check it before you ask such questions. It will be TERRIBLY, TERRIBLY annoying if you keep on asking those questions @vijayasarathib before checking it first. Please STOP before you go any further. |
This command can be used to semi-automatically update constraints in case we need to update historical version of them, because for some reason (like setuptools or pip or cython changes) we need to update individual constraints in historically released constraints.
c8b043b
to
702381d
Compare
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…33144) * Add update-constraints command that allows to modify released ones This command can be used to semi-automatically update constraints in case we need to update historical version of them, because for some reason (like setuptools or pip or cython changes) we need to update individual constraints in historically released constraints. --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit dcfca57)
…pache#33144) * Add update-constraints command that allows to modify released ones This command can be used to semi-automatically update constraints in case we need to update historical version of them, because for some reason (like setuptools or pip or cython changes) we need to update individual constraints in historically released constraints. --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This command can be used to semi-automatically update constraints in case we need to update historical version of them, because for some reason (like setuptools or pip or cython changes) we need to update individual constraints in historically released constraints.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.