Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-constraints command that allows to modify released ones #33144

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 5, 2023

This command can be used to semi-automatically update constraints in case we need to update historical version of them, because for some reason (like setuptools or pip or cython changes) we need to update individual constraints in historically released constraints.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the add-update-constraints-command branch 3 times, most recently from e27d7cf to 6905a40 Compare August 5, 2023 19:57
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really impressive PR! Few comments.

@potiuk potiuk force-pushed the add-update-constraints-command branch 3 times, most recently from 6481d43 to 6056bdd Compare August 7, 2023 14:22
@potiuk
Copy link
Member Author

potiuk commented Aug 7, 2023

When applying comments from @amoghrajesh I found out that the docs (especially the dev/MANUALLY...) could benefit from some consistency and similar structure for the different "manual" parts.

On one hand, it is unrelated change, on the other it's just updating the docs structure and content of a doc file tha we move and modify heavily so I went ahead and updated few more things in the same docs:

  • added context explaiing what the document is about and why sometimes we need to update/refresh image cache/constraints manually

  • reordered the chapters - first chapter explains how automated CI manages both image cache and constraints, then it explain how to manually refresh image cache, then how to manually refresh constraints, and eventually how to update already tagged constraints - seems it is much better and logical sequence

  • also ach chapter now contains similar structure:

    • why we might want to do it?
    • how to do it?
    • are there any dangers involved?

@potiuk
Copy link
Member Author

potiuk commented Aug 7, 2023

:D looking for some more reviews :)

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now!
Few nits which you can choose to ignore, @potiuk

@potiuk potiuk force-pushed the add-update-constraints-command branch from 6056bdd to 5b6e791 Compare August 8, 2023 09:48
@potiuk
Copy link
Member Author

potiuk commented Aug 8, 2023

Applied second round of comments.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small nit. Feel free to ignore

@potiuk potiuk force-pushed the add-update-constraints-command branch 4 times, most recently from 99cf1a4 to c8b043b Compare August 10, 2023 15:58
@potiuk
Copy link
Member Author

potiuk commented Aug 10, 2023

Breeze PR looks for approval :)

@potiuk potiuk requested a review from ephraimbuddy August 10, 2023 15:58
Copy link
Contributor

@vijayasarathib vijayasarathib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member Author

potiuk commented Aug 10, 2023

I appreciate the updates to the documentation structure and content. Could you confirm that the documentation is complete and aligns with the implemented functionality?

Please check it before you ask such questions. It will be TERRIBLY, TERRIBLY annoying if you keep on asking those questions @vijayasarathib before checking it first.

Please STOP before you go any further.

This command can be used to semi-automatically update constraints
in case we need to update historical version of them, because for
some reason (like setuptools or pip or cython changes) we need
to update individual constraints in historically released constraints.
@potiuk potiuk force-pushed the add-update-constraints-command branch from c8b043b to 702381d Compare August 10, 2023 19:38
potiuk and others added 2 commits August 11, 2023 00:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@potiuk potiuk merged commit dcfca57 into apache:main Aug 10, 2023
@potiuk potiuk deleted the add-update-constraints-command branch August 10, 2023 23:10
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone Aug 15, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 15, 2023
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2023

Verified

This commit was signed with the committer’s verified signature.
ephraimbuddy Ephraim Anierobi
…33144)

* Add update-constraints command that allows to modify released ones

This command can be used to semi-automatically update constraints
in case we need to update historical version of them, because for
some reason (like setuptools or pip or cython changes) we need
to update individual constraints in historically released constraints.

---------

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
(cherry picked from commit dcfca57)
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
…pache#33144)

* Add update-constraints command that allows to modify released ones

This command can be used to semi-automatically update constraints
in case we need to update historical version of them, because for
some reason (like setuptools or pip or cython changes) we need
to update individual constraints in historically released constraints.

---------

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants