Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Add UnimplementedStub to have forward compatible implementations #524

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Apr 16, 2021

Signed-off-by: Xuanwo github@xuanwo.io

…ntations

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo linked an issue Apr 16, 2021 that may be closed by this pull request
@Xuanwo Xuanwo requested review from Prnyself and JinnyYi April 16, 2021 07:18
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title types: Implement UnimplementedStub to have forward compatible implementations types: Add UnimplementedStub to have forward compatible implementations Apr 16, 2021
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Apr 16, 2021

PTAL @Prnyself

Copy link
Member

@Prnyself Prnyself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prnyself Prnyself merged commit 459ec84 into master Apr 16, 2021
@Prnyself Prnyself deleted the stub branch April 16, 2021 09:01
@Xuanwo Xuanwo mentioned this pull request Apr 16, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an UnimplementedStorager
2 participants