Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use order/handler for transformIndexHtml #590

Conversation

sapphi-red
Copy link
Contributor

enforce/transform of transformIndexHtml hook is deprecated since Vite 4. Also an runtime warning is added in Vite 5.

This PR changes that to use order/handler instead for Vite 4+.

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 6f23a3d
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6545db192d16b900086455ec
😎 Deploy Preview https://deploy-preview-590--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🎉

@userquin userquin merged commit 18af770 into vite-pwa:main Nov 4, 2023
3 checks passed
@sapphi-red sapphi-red deleted the refactor/use-order-handler-for-transform-index-html branch November 4, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants