feat: introduce ignoreOtherWorkspaces and enable by default

Author: antfu

README.md

@@ -97,6 +97,8 @@ export default defineConfig({
     '**/node_modules/**',
     '**/test/**',
   ],
+  // ignore package.json that in other workspaces (with their own .git,pnpm-workspace.yaml,etc.)
+  ignoreOtherWorkspaces: true,
   // override with different bumping mode for each package
   packageMode: {
     'typescript': 'major',

package.json

@@ -35,8 +35,10 @@
   },
   "dependencies": {
     "@antfu/ni": "^23.3.1",
+    "find-up-simple": "^1.0.0",
     "ofetch": "^1.4.1",
     "package-manager-detector": "^0.2.9",
+    "pathe": "^2.0.3",
     "tinyexec": "^0.3.2",
     "unconfig": "^7.0.0",
     "yaml": "^2.7.0",

pnpm-lock.yaml

@@ -48,6 +48,11 @@ function commonOptions(args: Argv<object>): Argv<CommonOptions> {
       type: 'string',
       describe: 'ignore paths for search package.json',
     })
+    .option('ignore-other-workspaces', {
+      type: 'boolean',
+      default: true,
+      describe: 'ignore package.json that in other workspaces (with their own .git,pnpm-workspace.yaml,etc.)',
+    })
     .option('include', {
       alias: 'n',
       type: 'string',

src/cli.ts

@@ -20,6 +20,7 @@ export const DEFAULT_COMMON_OPTIONS: CommonOptions = {
   recursive: false,
   force: false,
   ignorePaths: '',
+  ignoreOtherWorkspaces: true,
   include: '',
   exclude: '',
   depFields: {},

src/constants.ts

@@ -1,5 +1,5 @@
 import type { CommonOptions, PackageMeta, RawDep } from '../types'
-import path from 'node:path'
+import { resolve } from 'pathe'
 import { builtinAddons } from '../addons'
 import { dumpDependencies, getByPath, parseDependencies, parseDependency, setByPath } from './dependencies'
 import { readJSON, writeJSON } from './packages'
@@ -19,7 +19,7 @@ export async function loadPackageJSON(
   options: CommonOptions,
   shouldUpdate: (name: string) => boolean,
 ): Promise<PackageMeta[]> {
-  const filepath = path.resolve(options.cwd ?? '', relative)
+  const filepath = resolve(options.cwd ?? '', relative)
   const raw = await readJSON(filepath)
   const deps: RawDep[] = []
 

src/io/packageJson.ts

@@ -1,8 +1,10 @@
 import type { CommonOptions, PackageMeta } from '../types'
 import { existsSync, promises as fs } from 'node:fs'
-import path from 'node:path'
+import process from 'node:process'
 import detectIndent from 'detect-indent'
 import fg from 'fast-glob'
+import { findUp } from 'find-up-simple'
+import { dirname, join, resolve } from 'pathe'
 import { DEFAULT_IGNORE_PATHS } from '../constants'
 import { createDependenciesFilter } from '../utils/dependenciesFilter'
 import { loadPackageJSON, writePackageJSON } from './packageJson'
@@ -46,6 +48,7 @@ export async function loadPackage(
 export async function loadPackages(options: CommonOptions): Promise<PackageMeta[]> {
   let packagesNames: string[] = []
 
+  const cwd = resolve(options.cwd || process.cwd())
   const filter = createDependenciesFilter(options.include, options.exclude)
 
   if (options.recursive) {
@@ -61,7 +64,25 @@ export async function loadPackages(options: CommonOptions): Promise<PackageMeta[
     packagesNames = ['package.json']
   }
 
-  if (existsSync(path.join(options.cwd || '', 'pnpm-workspace.yaml'))) {
+  if (options.ignoreOtherWorkspaces) {
+    packagesNames = (await Promise.all(
+      packagesNames.map(async (packagePath) => {
+        if (!packagePath.includes('/'))
+          return [packagePath]
+
+        const absolute = join(cwd, packagePath)
+        const gitDir = await findUp('.git', { cwd: absolute, stopAt: cwd })
+        if (gitDir && dirname(gitDir) !== cwd)
+          return []
+        const pnpmWorkspace = await findUp('pnpm-workspace.yaml', { cwd: absolute, stopAt: cwd })
+        if (pnpmWorkspace && dirname(pnpmWorkspace) !== cwd)
+          return []
+        return [packagePath]
+      }),
+    )).flat()
+  }
+
+  if (existsSync(join(cwd, 'pnpm-workspace.yaml'))) {
     packagesNames.unshift('pnpm-workspace.yaml')
   }
 

src/io/packages.ts

@@ -1,8 +1,8 @@
 import type { Scalar } from 'yaml'
 import type { CommonOptions, PnpmWorkspaceMeta, RawDep } from '../types'
 import fs from 'node:fs/promises'
-import path from 'node:path'
 import _debug from 'debug'
+import { resolve } from 'pathe'
 import { isAlias, parse, parseDocument, YAMLMap } from 'yaml'
 import { findAnchor, writeYaml } from '../utils/yaml'
 import { dumpDependencies, parseDependency } from './dependencies'
@@ -14,7 +14,7 @@ export async function loadPnpmWorkspace(
   options: CommonOptions,
   shouldUpdate: (name: string) => boolean,
 ): Promise<PnpmWorkspaceMeta[]> {
-  const filepath = path.resolve(options.cwd ?? '', relative)
+  const filepath = resolve(options.cwd ?? '', relative)
   const rawText = await fs.readFile(filepath, 'utf-8')
   const raw = parse(rawText)
   const document = parseDocument(rawText)

src/io/pnpmWorkspaces.ts

@@ -1,9 +1,9 @@
 import type { CheckOptions, DependencyFilter, DependencyResolvedCallback, DiffType, PackageData, PackageMeta, RangeMode, RawDep, ResolvedDepChange } from '../types'
 import { existsSync, promises as fs, lstatSync } from 'node:fs'
 import os from 'node:os'
-import { resolve } from 'node:path'
 import _debug from 'debug'
 import pLimit from 'p-limit'
+import { resolve } from 'pathe'
 import semver from 'semver'
 import { diffSorter } from '../filters/diff-sorter'
 import { getPackageMode } from '../utils/config'

src/io/resolves.ts

@@ -63,6 +63,7 @@ export interface CommonOptions {
   cwd?: string
   recursive?: boolean
   ignorePaths?: string | string[]
+  ignoreOtherWorkspaces?: boolean
   include?: string | string[]
   exclude?: string | string[]
   loglevel?: LogLevel

src/types.ts

@@ -1,14 +1,14 @@
 // ported from: https://github.com/raineorshine/npm-check-updates/blob/master/lib/package-managers/npm.js
 
 import type { Recordable } from '@npmcli/config'
-import path from 'node:path'
 import process from 'node:process'
+import { dirname, join } from 'pathe'
 
 async function _getNpmConfig() {
   const { default: NpmCliConfig } = await import('@npmcli/config')
   const npmcliConfig = new NpmCliConfig({
     definitions: {},
-    npmPath: path.dirname(process.cwd()),
+    npmPath: dirname(process.cwd()),
     flatten: (current, total) => {
       Object.assign(total, current)
     },
@@ -24,8 +24,8 @@ async function _getNpmConfig() {
       if (cli)
         cli.data[key] = value
     }
-    setCliOption('userconfig', path.join(npmcliConfig.home, '.npmrc'))
-    setCliOption('globalconfig', path.join(npmcliConfig.globalPrefix, 'etc', 'npmrc'))
+    setCliOption('userconfig', join(npmcliConfig.home, '.npmrc'))
+    setCliOption('globalconfig', join(npmcliConfig.globalPrefix, 'etc', 'npmrc'))
   }
 
   // npmcliConfig.load() would set unnecessary environment variables

src/utils/npm.ts

@@ -1,9 +1,9 @@
-import path from 'node:path'
+import { resolve } from 'pathe'
 import { exec } from 'tinyexec'
 import { expect, it } from 'vitest'
 
 it('taze cli should just works', async () => {
-  const binPath = path.resolve(__dirname, '../bin/taze.mjs')
+  const binPath = resolve(__dirname, '../bin/taze.mjs')
 
   const proc = await exec(process.execPath, [binPath], { throwOnError: true })
 

test/cli.test.ts

@@ -1,6 +1,6 @@
 import type { CheckOptions, CommonOptions, ResolvedDepChange } from '../src'
-import { join } from 'node:path'
 import process from 'node:process'
+import { join } from 'pathe'
 import { describe, expect, it } from 'vitest'
 import { CheckPackages } from '../src'
 import { resolveConfig } from '../src/config'