Skip to content

Commit 645e312

Browse files
authoredFeb 4, 2025··
fix: sort by alias name (#159)
1 parent dcbd53a commit 645e312

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed
 

Diff for: ‎src/io/dependencies.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function dumpDependencies(deps: ResolvedDepChange[], type: DepType) {
4646
const data: Record<string, any> = {}
4747
deps
4848
.filter(i => i.source === type)
49-
.sort((a, b) => a.name.localeCompare(b.name))
49+
.sort((a, b) => (a.aliasName || a.name).localeCompare(b.aliasName || b.name))
5050
.forEach((i) => {
5151
const version = i.update ? i.targetVersion : i.currentVersion
5252
let targetLeaf = data

Diff for: ‎test/dumpDependencies.test.ts

+12-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import type { ResolvedDepChange } from '../src/types'
1+
import type { DepType, ResolvedDepChange } from '../src/types'
22
import { describe, expect, it } from 'vitest'
33
import { dumpDependencies } from '../src/io/dependencies'
44

55
describe('dumpDependencies', () => {
6-
function makeDepChange(source: string, override: Partial<ResolvedDepChange> = {}) {
6+
function makeDepChange(source: DepType, override: Partial<ResolvedDepChange> = {}) {
77
return {
88
name: '@types/semver',
99
currentVersion: '^7.3.10',
@@ -89,4 +89,14 @@ describe('dumpDependencies', () => {
8989
}
9090
`)
9191
})
92+
93+
it('dump sorted by key', () => {
94+
const dump = dumpDependencies([
95+
makeDepChange('dependencies', { name: 'd', aliasName: 'a' }),
96+
makeDepChange('dependencies', { name: 'c' }),
97+
makeDepChange('dependencies', { name: 'b' }),
98+
], 'dependencies')
99+
expect(Object.keys(dump)).toEqual(['a', 'b', 'c'],
100+
)
101+
})
92102
})

0 commit comments

Comments
 (0)
Please sign in to comment.