Skip to content

Commit 13dcf44

Browse files
authoredJan 9, 2025··
fix: invalid version when checking vscode engine (#147)
1 parent a778512 commit 13dcf44

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed
 

‎src/addons/vscode.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ export const addonVSCode: Addon = {
1010
return
1111
}
1212

13+
const minEngineVersion = semver.minVersion(pkg.raw.engines.vscode)
14+
if (!minEngineVersion) {
15+
return
16+
}
17+
1318
const version: string = pkg.raw.dependencies?.['@types/vscode']
1419
|| pkg.raw.devDependencies?.['@types/vscode']
1520
|| pkg.raw.peerDependencies?.['@types/vscode']
@@ -20,7 +25,7 @@ export const addonVSCode: Addon = {
2025
return
2126
}
2227

23-
if (version && semver.gt(version, pkg.raw.engines.vscode)) {
28+
if (version && semver.gt(version, minEngineVersion)) {
2429
// eslint-disable-next-line no-console
2530
console.log(`[taze addon] Updated VS Code engine field to ${version}`)
2631
// If the version is not a range (fixed version), we prepend it with a caret

0 commit comments

Comments
 (0)
Please sign in to comment.