Stream Parser Support - pt3 - create parser context object and turn parse() function into parser.parse()
#35
+83
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2020 07:56
… `parse()` function into `parser.parse()` Eventually streaming parser needs to remember state in between client calls, thus we have to save those into a `parser` context object. This PR simply creates the `parser` context object and turns `parse()` the standalone function into a method on `parser` object. Move all the state variables into `parser` object. Other than that, the functionalities and code paths remain unchanged.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream Parser Support - pt3 - create
parsercontext object and turnparse()function intoparser.parse()Eventually streaming parser needs to remember state in between client calls, thus we have to save those into a
parsercontext object. This PR simply creates theparsercontext object and turnsparse()the standalone function into a method onparserobject. Move all the state variables intoparserobject. Other than that, the functionalities and code paths remain unchanged.