Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: react-scan default not run #53161

Merged
merged 4 commits into from
Mar 17, 2025
Merged

chore: react-scan default not run #53161

merged 4 commits into from
Mar 17, 2025

Conversation

wanpan11
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

默认不开启扫描,好卡=.=
image

📝 Change Log

Language Changelog
🇺🇸 English
🇨🇳 Chinese

Sorry, something went wrong.

Copy link

stackblitz bot commented Mar 14, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 14, 2025

👁 Visual Regression Report for PR #53161 Passed ✅

🎯 Target branch: master (d1ae2aa)
📖 View Full Report ↗︎
📖 Alternative Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Preview is ready

Copy link

Walkthrough

This pull request modifies the behavior of the react-scan tool in the development environment. The scan is now disabled by default to improve performance, with an option to show the toolbar and log render information. Additionally, the react-scan package version is updated in package.json.

Changes

Files Summary
.dumi/theme/layouts/GlobalLayout.tsx Modified the react-scan configuration to disable scanning by default in non-production environments and added the option to show the toolbar.
package.json Updated the react-scan package version from ^0.2.0 to ^0.2.14.


if (process.env.NODE_ENV !== 'production') {
scan({
enabled: false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that disabling the scan by default does not affect any critical functionality in development. This change should be thoroughly tested to confirm that it does not inadvertently hide important information during the development process.

@wanpan11 wanpan11 changed the title chore: react-scan default noy run chore: react-scan default not run Mar 14, 2025
Copy link

pkg-pr-new bot commented Mar 14, 2025

Copy link

codecov bot commented Mar 14, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d1ae2aa) to head (f925067).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #53161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          770       770           
  Lines        13885     13885           
  Branches      3639      3639           
=========================================
  Hits         13885     13885           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

afc163
afc163 previously approved these changes Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: afc163 <afc163@gmail.com>
Copy link

socket-security bot commented Mar 17, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@ant-design/colors@7.2.0, npm/@ant-design/compatible@5.1.4, npm/@ant-design/cssinjs-utils@2.0.0-alpha.1, npm/@ant-design/cssinjs@2.0.0-alpha.5, npm/@ant-design/fast-color@2.0.6, npm/@ant-design/happy-work-theme@1.0.0, npm/@ant-design/icons@5.6.1, npm/@ant-design/react-slick@1.1.2, npm/@ant-design/tools@18.1.3-alpha.2, npm/@ant-design/v5-patch-for-react-19@1.0.3, npm/@antfu/eslint-config@4.10.1, npm/@antv/g6@5.0.0-beta.40, npm/@babel/runtime@8.0.0-alpha.17, npm/@biomejs/biome@1.9.5-nightly.ff02a0b, npm/@codecov/webpack-plugin@1.9.0, npm/@codesandbox/sandpack-react@2.20.0, npm/@dnd-kit/core@6.3.1, npm/@dnd-kit/modifiers@9.0.0, npm/@dnd-kit/sortable@10.0.0, npm/@dnd-kit/utilities@3.2.2, npm/@emotion/css@11.13.5, npm/@emotion/react@11.14.0, npm/@emotion/server@11.11.0, npm/@eslint-react/eslint-plugin@1.34.2-next.0, npm/@ianvs/prettier-plugin-sort-imports@4.4.1, npm/@inquirer/prompts@7.4.0, npm/@madccc/duplicate-package-checker-webpack-plugin@1.0.0, npm/@microflash/rehype-figure@2.1.3, npm/@npmcli/run-script@9.1.0, npm/@octokit/rest@21.1.1, npm/@qixian.cs/github-contributors-list@2.0.2, npm/@rc-component/color-picker@2.0.1, npm/@rc-component/mutate-observer@1.1.0, npm/@rc-component/qrcode@1.0.0, npm/@rc-component/tour@1.15.1, npm/@rc-component/trigger@2.2.6, npm/@size-limit/file@11.2.0, npm/@stackblitz/sdk@1.11.0, npm/@testing-library/dom@10.4.0, npm/@testing-library/jest-dom@6.6.3, npm/@testing-library/react@16.2.0, npm/@testing-library/user-event@14.6.1, npm/@types/adm-zip@0.5.7, npm/@types/ali-oss@6.16.11, npm/@types/cli-progress@3.11.6, npm/@types/fs-extra@11.0.4, npm/@types/gtag.js@0.0.20, npm/@types/http-server@0.12.4, npm/@types/isomorphic-fetch@0.0.39, npm/@types/jest-axe@3.5.9, npm/@types/jest-environment-puppeteer@5.0.6, npm/@types/jest-image-snapshot@6.4.0, npm/@types/jest@29.5.14, npm/@types/jquery@3.5.32, npm/@types/jsdom@21.1.7, npm/@types/node@22.13.10, npm/@types/nprogress@0.2.3, npm/@types/pixelmatch@5.2.6, npm/@types/pngjs@6.0.5, npm/@types/prismjs@1.26.5, npm/@types/progress@2.0.7, npm/@types/react-copy-to-clipboard@5.0.7, npm/@types/react-dom@19.0.4, npm/@types/react-highlight-words@0.20.0, npm/@types/react-resizable@3.0.8, npm/@types/react@19.0.10, npm/@types/semver@7.5.8, npm/@types/spinnies@0.5.3, npm/@types/tar@6.1.13, npm/@types/throttle-debounce@5.0.2, npm/@types/warning@3.0.3, npm/adm-zip@0.5.16, npm/ali-oss@7.0.0-test.1, npm/antd-img-crop@4.24.0, npm/antd-style@3.7.2-alpha.1, npm/antd-token-previewer@3.0.0-alpha.0, npm/axios@1.8.3, npm/chalk@5.4.1, npm/cheerio@1.0.0, npm/circular-dependency-plugin@5.2.2, npm/cli-progress@3.12.0, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.1.0, npm/cypress-image-diff-html-report@2.2.0, npm/dekko@0.2.1, npm/dumi-plugin-color-chunk@1.1.2, npm/dumi@2.4.19-beta.0, npm/env-paths@3.0.0, npm/eslint-plugin-compat@6.0.2, npm/eslint-plugin-jest@28.11.0, npm/eslint-plugin-jsx-a11y@6.10.2, npm/eslint-plugin-react-hooks@5.2.0, npm/eslint-plugin-react-refresh@0.4.19, npm/eslint@9.22.0, npm/fast-glob@3.3.3, npm/fs-extra@11.3.0, npm/gh-pages@6.3.0, npm/glob@11.0.1, npm/html2sketch@1.0.2, npm/http-server@14.1.1, npm/husky@9.1.7, npm/identity-obj-proxy@3.0.0, npm/immer@10.1.1, npm/is-ci@4.1.0, npm/isomorphic-fetch@3.0.0, npm/jest-axe@10.0.0, npm/jest-canvas-mock@2.5.2, npm/jest-environment-jsdom@30.0.0-alpha.7, npm/jest-environment-node@30.0.0-alpha.7, npm/jest-image-snapshot@6.4.0, npm/jest-puppeteer@11.0.0, npm/jest@30.0.0-alpha.7, npm/jquery@4.0.0-beta.2, npm/jsdom@26.0.0, npm/jsonml-to-react-element@1.1.11, npm/jsonml.js@0.1.0, npm/lint-staged@15.5.0, npm/lunar-typescript@1.7.8, npm/lz-string@1.5.0, npm/mockdate@3.0.5, npm/node-fetch@4.0.0-beta.4, npm/node-notifier@10.0.1, npm/open@10.1.0, npm/ora@8.2.0, npm/p-all@5.0.0, npm/package-manager-detector@1.1.0, npm/pixelmatch@7.1.0, npm/pngjs@7.0.0, npm/prettier@4.0.0-alpha.12, npm/pretty-format@30.0.0-alpha.7, npm/puppeteer@24.4.0, npm/rc-cascader@3.33.1, npm/rc-checkbox@3.5.0, npm/rc-collapse@3.9.0, npm/rc-dialog@9.6.0, npm/rc-drawer@7.2.0, npm/rc-dropdown@4.2.1, npm/rc-field-form@2.7.0, npm/rc-footer@0.6.8, npm/rc-image@7.11.0, npm/rc-input-number@9.4.0, npm/rc-input@1.7.3, npm/rc-mentions@2.19.1, npm/rc-menu@9.16.1, npm/rc-motion@2.9.5, npm/rc-notification@5.6.3, npm/rc-pagination@5.1.0, npm/rc-picker@4.11.3, npm/rc-progress@4.0.0, npm/rc-rate@2.13.1, npm/rc-resize-observer@1.4.3, npm/rc-segmented@2.7.0, npm/rc-select@14.16.6, npm/rc-slider@11.1.8, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-table@7.50.4, npm/rc-tabs@15.5.1, npm/rc-textarea@1.9.0, npm/rc-tooltip@6.4.0, npm/rc-tree-select@5.27.0, npm/rc-tree@5.13.1, npm/rc-tween-one@3.0.6, npm/rc-upload@4.8.1, npm/rc-util@5.44.4, npm/rc-virtual-list@3.18.4, npm/react-copy-to-clipboard@5.1.0, npm/react-countup@6.5.3, npm/react-dom@19.1.0-canary-ff628334-20250205, npm/react-draggable@4.4.6, npm/react-fast-marquee@1.6.5, npm/react-highlight-words@0.21.0, npm/react-icons@5.5.0, npm/react-infinite-scroll-component@6.1.0, npm/react-intersection-observer@9.16.0, npm/react-resizable@3.0.5, npm/react-router-dom@7.3.0, npm/react-scan@0.2.14, npm/react-sticky-box@2.0.5, npm/rehype-stringify@10.0.1, npm/remark-cli@12.0.1, npm/remark-gfm@4.0.1, npm/remark-lint-no-undefined-references@5.0.1, npm/remark-lint@10.0.1, npm/remark-preset-lint-recommended@7.0.1, npm/remark-rehype@11.1.1, npm/remark@15.0.1, npm/rimraf@6.0.1, npm/runes2@1.1.4, npm/scroll-into-view-if-needed@3.1.0, npm/sharp@0.34.0-rc.0, npm/simple-git@3.27.0, npm/size-limit@11.2.0, npm/spinnies@0.5.1, npm/sylvanas@0.6.1, npm/tar-fs@3.0.8, npm/tar@7.4.3, npm/terser@5.39.0, npm/throttle-debounce@5.0.2, npm/tsx@4.19.3, npm/typedoc@0.28.0, npm/vanilla-jsoneditor@3.1.0, npm/vanilla-tilt@1.8.1, npm/webpack-bundle-analyzer@4.10.2, npm/webpack@5.98.0, npm/xhr-mock@2.5.1

View full report↗︎

afc163 and others added 2 commits March 17, 2025 11:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@afc163 afc163 merged commit b6bac7d into ant-design:master Mar 17, 2025
41 checks passed
@wanpan11 wanpan11 deleted the scan branch March 17, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants