Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): optimize fetchData for table #48560

Merged
merged 1 commit into from Apr 20, 2024
Merged

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Apr 20, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • Demo update

🔗 Related issue link

close #48550

💡 Background and solution

第一次请求会修改total,会造成重复请求

📝 Changelog

Language Changelog
🇺🇸 English fix(demo): optimize fetchData for table
🇨🇳 Chinese fix(demo): 优化table网络请求的demo

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 20, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 20, 2024

👁 Visual Regression Report for PR #48560 Passed ✅

🎯 Target branch: master (0bc2e3a)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0bc2e3a) to head (5a18c05).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12887     12887           
  Branches      3371      3371           
=========================================
  Hits         12887     12887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit f6db43b into ant-design:master Apr 20, 2024
66 checks passed
Enigama pushed a commit to Enigama/ant-design that referenced this pull request Apr 20, 2024
@thinkasany thinkasany deleted the demo-opt branch May 6, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table demo示例中远程加载数据,第一次会出现两次请求的bug
2 participants