Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SyntaxWarning on import #349

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix: SyntaxWarning on import #349

merged 2 commits into from
Apr 1, 2024

Conversation

greschd
Copy link
Member

@greschd greschd commented Mar 28, 2024

Fixes #348

@greschd greschd requested a review from a team as a code owner March 28, 2024 22:50
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 28, 2024
SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 29, 2024
View reviewed changes
Copy link

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys dismissed their stale review March 29, 2024 08:03

Doc build is failing

@SMoraisAnsys SMoraisAnsys mentioned this pull request Mar 29, 2024
Closed
2 tasks
@SMoraisAnsys
Copy link

@greschd Seems like the doc build isn't related to your changes, wait for #351 to be fixed and CICD should be fine after

MaxJPRey
MaxJPRey approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

RobPasMue
RobPasMue approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @greschd

@RobPasMue RobPasMue changed the title Fix SyntaxWarning on import fix: SyntaxWarning on import Apr 1, 2024
@RobPasMue RobPasMue enabled auto-merge (squash) April 1, 2024 07:08
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Apr 1, 2024
@RobPasMue RobPasMue merged commit edaeb47 into main Apr 1, 2024
22 checks passed
@RobPasMue RobPasMue deleted the maint/fix_syntaxwarnings branch April 1, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

Assignees
No one assigned
Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxWarning when running with Python 3.12
4 participants
@greschd @SMoraisAnsys @RobPasMue @MaxJPRey