Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update templates for sphinx-autoapi==3.1.0a4 #347

Merged
merged 13 commits into from
Apr 1, 2024

Conversation

Revathyvenugopal162
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 26, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it out on some repos with version 3.0.0a4?

@Revathyvenugopal162
Copy link
Collaborator Author

Did you try it out on some repos with version 3.0.0a4?

Testing it locally with pyansys-geometry. I can open a PR with my branch.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great now! Thank you both @jorgepiloto and @Revathyvenugopal162

Fine on my side to merge

@RobPasMue
Copy link
Member

Verified in ansys/pyansys-geometry#1086

@jorgepiloto jorgepiloto marked this pull request as ready for review April 1, 2024 09:05
@jorgepiloto jorgepiloto requested a review from a team as a code owner April 1, 2024 09:05
@jorgepiloto jorgepiloto changed the title fix: Update the template for autoapi fix: update templates for sphinx-autoapi==3.1.0a4 Apr 1, 2024
@jorgepiloto jorgepiloto merged commit 47c3745 into main Apr 1, 2024
25 checks passed
@jorgepiloto jorgepiloto deleted the feat/autoapi-template branch April 1, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants