Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.16] expect - fix argument spec error with timeout=null (#82522) #82608

Merged
merged 2 commits into from Feb 14, 2024
Merged

[2.16] expect - fix argument spec error with timeout=null (#82522) #82608

merged 2 commits into from Feb 14, 2024

Conversation

s-hertel
Copy link
Contributor

SUMMARY

  • Fix using timeout=null to wait indefinitely

  • fix error message

(cherry picked from commit da9edd7)

ISSUE TYPE
  • Bugfix Pull Request

@s-hertel
expect - fix argument spec error with timeout=null (ansible#82522)
fbb9703 
* Fix using timeout=null to wait indefinitely

* fix error message

(cherry picked from commit da9edd7)
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. module This issue/PR relates to a module. labels Jan 26, 2024
@ansibot
Copy link
Contributor

ansibot commented Jan 26, 2024

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/expect.py:170:124: SyntaxError: module.fail_json(msg=f"argument 'timeout' is of type {type(timeout)} and we were unable to convert to int: {te}")

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/expect.py:170:124: traceback: SyntaxError: invalid syntax (at test/lib/ansible_test/_util/target/sanity/import/importer.py:297:0)

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 26, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 26, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Jan 26, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 9, 2024
@sivel
Copy link
Member

sivel commented Feb 14, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 14, 2024
@sivel sivel merged commit 9a07ab7 into ansible:stable-2.16 Feb 14, 2024
78 checks passed
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 19, 2024
@ansible ansible locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug. module This issue/PR relates to a module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s-hertel @ansibot @sivel @webknjaz