Do not ignore SyntaxError from jinja2.Environment.from_string #82607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja may generate an invalid Python source code from a template. Trying to compile such source code into a Python code object results in SyntaxError being thrown. An example of such a template is providing the same keyword argument into a lookup twice, resulting in: `SyntaxError: keyword argument repeated`. Since `jinja2.exceptions.TemplateSyntaxError` does not cover such a case, as it is not a Jinja parsing error, we need to catch SyntaxError explicitly ourselves. Fixes ansible#82606
ansibot
added
bug
nitzmahone
approved these changes
Jan 26, 2024
OK, I seem to have tested against outdated DT branch where this was still an issue and removing https://github.com/ansible/ansible/pull/82607/files#diff-8900ff472220a4c25fcc888ae62fdda2b036e5f20b343fb58819f97c6b82cc22R950 there recently fixed that. Merging for the test and as a way for a simple backport. |
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Jan 29, 2024
…e#82607) Jinja may generate an invalid Python source code from a template. Trying to compile such source code into a Python code object results in SyntaxError being thrown. An example of such a template is providing the same keyword argument into a lookup twice, resulting in: `SyntaxError: keyword argument repeated`. Since `jinja2.exceptions.TemplateSyntaxError` does not cover such a case, as it is not a Jinja parsing error, we need to catch SyntaxError explicitly ourselves. Fixes ansible#82606 (cherry picked from commit 6d34eb8)
bcoca
removed
the
needs_triage
sivel
pushed a commit
that referenced
this pull request
Feb 14, 2024
#82614) Jinja may generate an invalid Python source code from a template. Trying to compile such source code into a Python code object results in SyntaxError being thrown. An example of such a template is providing the same keyword argument into a lookup twice, resulting in: `SyntaxError: keyword argument repeated`. Since `jinja2.exceptions.TemplateSyntaxError` does not cover such a case, as it is not a Jinja parsing error, we need to catch SyntaxError explicitly ourselves. Fixes #82606 (cherry picked from commit 6d34eb8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Jinja may generate an invalid Python source code from a template. Trying to compile such source code into a Python code object results in SyntaxError being thrown. An example of such a template is providing the same keyword argument into a lookup twice, resulting in:
SyntaxError: keyword argument repeated.Since
jinja2.exceptions.TemplateSyntaxErrordoes not cover such a case, as it is not a Jinja parsing error, we need to catch SyntaxError explicitly ourselves.Fixes #82606
ISSUE TYPE