New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-config dedupe ini plugin entries #82498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
has_issue
labels
Jan 8, 2024
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jan 8, 2024
added test for ini file integrity, also ensuring no dupes
ansibot
removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
ci_verified
Changes made in this PR are causing tests to fail.
labels
Jan 8, 2024
jborean93
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor nits in the testing side.
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jan 9, 2024
added test for ini file integrity, also ensuring no dupes (cherry picked from commit 6c2895f)
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Jan 9, 2024
added test for ini file integrity, also ensuring no dupes (cherry picked from commit 6c2895f)
mattclay
pushed a commit
that referenced
this pull request
Jan 19, 2024
added test for ini file integrity, also ensuring no dupes (cherry picked from commit 6c2895f)
mattclay
pushed a commit
that referenced
this pull request
Jan 19, 2024
added test for ini file integrity, also ensuring no dupes (cherry picked from commit 6c2895f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82481
ISSUE TYPE