-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Unsafe fixes #82376
Merged
Merged
Additional Unsafe fixes #82376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
backport
This PR does not target the devel branch.
labels
Dec 6, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
1 task
nitzmahone
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor nit, otherwise LGTM
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
Dec 7, 2023
ansibot
added
the
stale_review
Updates were made after the last review and the last review is more than 7 days old.
label
Dec 7, 2023
nitzmahone
approved these changes
Dec 7, 2023
ansibot
removed
the
stale_review
Updates were made after the last review and the last review is more than 7 days old.
label
Dec 7, 2023
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Dec 7, 2023
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356 * Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375 * clog frag (cherry picked from commit afe3fc1) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Dec 7, 2023
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356 * Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375 * clog frag (cherry picked from commit afe3fc1) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Dec 11, 2023
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356 * Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375 * clog frag (cherry picked from commit afe3fc1) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Dec 11, 2023
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356 * Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375 * clog frag (cherry picked from commit afe3fc1) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
added a commit
that referenced
this pull request
Dec 11, 2023
sivel
added a commit
that referenced
this pull request
Dec 11, 2023
sivel
removed
the
needs_triage
Needs a first human triage before being processed.
label
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport
This PR does not target the devel branch.
bug
This issue/PR relates to a bug.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Additional Unsafe fixes
Fixes #82356 - pickling with
protocol=0
Fixes #82375 - Fixes bytes iteration expectations
ISSUE TYPE
ADDITIONAL INFORMATION