Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ansible.builtin.include_vars - depth #80995

Merged
merged 4 commits into from Jan 18, 2024
Merged

Fix ansible.builtin.include_vars - depth #80995

merged 4 commits into from Jan 18, 2024

Conversation

tachyontec
Copy link
Contributor

SUMMARY

Changed vars.py, so it starts from depth 1 as root, as suggested by @sivel

Fixes #80987

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vars.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 7, 2023

@tachyontec this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.16 bug This issue/PR relates to a bug. merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 7, 2023
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 7, 2023
@jborean93 jborean93 changed the title Fixing #80987 Fix ansible.builtin.include_vars - depth Jun 8, 2023
jborean93
jborean93 previously requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add a test for this scenario to avoid any future regressions. It also requires a changelog fragment to document this bugfix https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jun 8, 2023
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 8, 2023
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 16, 2023
@ansibot
Copy link
Contributor

ansibot commented Jun 20, 2023

@tachyontec this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 20, 2023
@ansibot
Copy link
Contributor

ansibot commented Jun 20, 2023

@tachyontec this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 20, 2023
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 20, 2023
@tachyontec
Copy link
Contributor Author

Tests passed, I think we are ready to merge ;)

@ansibot
Copy link
Contributor

ansibot commented Jun 23, 2023

@tachyontec this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2023
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2023
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. has_issue labels Jul 5, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 17, 2024
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 17, 2024
@s-hertel s-hertel dismissed jborean93’s stale review January 18, 2024 16:43

a changelog and test were added

@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jan 18, 2024
@s-hertel s-hertel merged commit 48bed1e into ansible:devel Jan 18, 2024
62 checks passed
s-hertel pushed a commit to s-hertel/ansible that referenced this pull request Jan 26, 2024
@tachyontec @s-hertel
Fix ansible.builtin.include_vars - depth (ansible#80995)
3f6bab4 
* Changes as suggested by sivel

* Add changelog fragment and tests

Co-authored-by: Matt Martz <matt@sivel.net>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit 48bed1e)
sivel pushed a commit that referenced this pull request Feb 14, 2024
@s-hertel @tachyontec
Fix ansible.builtin.include_vars - depth (#80995) (#82610)
74f99dc 
* Changes as suggested by sivel

* Add changelog fragment and tests

Co-authored-by: Matt Martz <matt@sivel.net>
Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
(cherry picked from commit 48bed1e)

Co-authored-by: tachyontec <92679798+tachyontec@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel left review comments

@jborean93 jborean93 jborean93 left review comments

Assignees
No one assigned
Labels
affects_2.16 bug This issue/PR relates to a bug. has_issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible.builtin.include_vars - depth doesn't work as described
4 participants
@tachyontec @ansibot @jborean93 @s-hertel