Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ignore_unreachable accept jinja templates #4120

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Make ignore_unreachable accept jinja templates #4120

merged 1 commit into from
Apr 30, 2024
+371 −16

Conversation

audgirka
Copy link
Contributor

Fixes: #4085

@audgirka audgirka requested a review from a team as a code owner April 23, 2024 08:14
@audgirka audgirka requested review from ssbarnea and shatakshiiii and removed request for a team April 23, 2024 08:14
@github-actions github-actions bot added the bug label Apr 23, 2024
ssbarnea
ssbarnea previously requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include an use of templated value for the ignore_reachable in the schema test files, so we would not accidentally remove it in the future.

@audgirka audgirka requested a review from ssbarnea April 23, 2024 08:26
@ssbarnea ssbarnea marked this pull request as ready for review April 30, 2024 10:44
@ssbarnea ssbarnea changed the title Allow ignore_unreachable to be evaluated with jinja template Allow ignore_unreachable to be a jinja template Apr 30, 2024
@ssbarnea ssbarnea changed the title Allow ignore_unreachable to be a jinja template Make ignore_unreachable accept jinja templates Apr 30, 2024
@ssbarnea ssbarnea enabled auto-merge (squash) April 30, 2024 10:53
@ssbarnea ssbarnea disabled auto-merge April 30, 2024 10:56
@ssbarnea ssbarnea merged commit dfb8fea into ansible:main Apr 30, 2024
22 of 23 checks passed
@audgirka audgirka deleted the fix/4085 branch April 30, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore_unreachable doesnt work with jinja templates
2 participants
@audgirka @ssbarnea