Don't inject CWD parent into PATH #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymm
requested review from
ssbarnea and
priyamsahoo
and removed request for
a team
|
An alternate fix for my issue would be to check if |
previously if own_location was set to "", then
os.path.realpath("") resolves to CWD, and then
if CWD/../ansible exists, CWD/.. was injected into PATH.
This doesn't seem desirable or necessary.
Qalthos
force-pushed
the
garymm/fix-path-inject
branch
from
77a5e02
to
5385390
Compare
ssbarnea
changed the title
ssbarnea
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if own_location was set to "", then os.path.realpath("") resolves to CWD, and then
if CWD/../ansible exists, CWD/.. was injected into PATH. This doesn't seem desirable or necessary.