-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not assume working_directory is github.workspace #4103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `working_directory` for ansible-lint action would fail due to hard-coded `.git`, introduced in commit 6f728e0, when fetching `.config/requirements-lock.txt`. This fix replaces `.git` with `${{ github.workspace }}/.git` to make `working_directory` argument work again.
ajfabbri
requested review from
ssbarnea and
Qalthos
and removed request for
a team
April 9, 2024 19:37
Qalthos
approved these changes
Apr 25, 2024
Qalthos
approved these changes
Apr 25, 2024
ssbarnea
changed the title
Fix #3938: don't assume working_directory is github.workspace
Do not assume working_directory is github.workspace
Apr 30, 2024
Thanks for this PR. I was waiting for this but then I encountered this bug actions/runner#2058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
working_directory
for ansible-lint action would fail due to hard-coded.git
, introduced in commit 6f728e0, when fetching.config/requirements-lock.txt
.This fix replaces
.git
with${{ github.workspace }}/.git
to makeworking_directory
argument work again.Tested that this does fix my github action, i.e.:
Fixes #3938