Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raise-missing-from rule #3885

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Add raise-missing-from rule #3885

merged 2 commits into from
Apr 21, 2023

Conversation

Ruchip16
Copy link
Member

The raise-missing-from error occurs when we catch an exception and raise a new exception with the original exception as the cause, but we do not explicitly use the from clause to include the original exception as the cause in the new exception. Hence to fix this, we can use the from clause when raising the new exception to explicitly specify the original exception as the cause. This would make the work easier to trace the original cause of the error when debugging.

@Ruchip16 Ruchip16 added the bug label Apr 21, 2023
@Ruchip16 Ruchip16 self-assigned this Apr 21, 2023
@Ruchip16 Ruchip16 requested review from a team as code owners April 21, 2023 13:29
@Ruchip16 Ruchip16 requested review from odyssey4me, sky-joker, ganeshrn, trishnaguha, cidrblock, ssbarnea and a team and removed request for a team April 21, 2023 13:29
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You included this file my mistake, remove it.

@Ruchip16
Copy link
Member Author

You included this file my mistake, remove it.

ohh no yes removing it

@Ruchip16 Ruchip16 requested a review from ssbarnea April 21, 2023 13:47
@ssbarnea ssbarnea merged commit ebe109e into main Apr 21, 2023
@ssbarnea ssbarnea deleted the bugfix branch April 21, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants