Add kubevirt.core to Ansible 10 and 11 #419
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
|
Just wanted to ask if this shouldn't be added to |
|
And indeed there was a 10.0.1 release :) Let's wait a few more days, not that we need to do yet another 10.0.2 release... |
|
The next minor releases are coming up (next week), so let's merge this ;) |
|
Hmm, maybe merging this was a mistake. kubevirt.core has a very specific kubernetes.core dependency: |
|
I created kubevirt/kubevirt.core#110. |
felixfontein
added a commit
to felixfontein/ansible-build-data
that referenced
this pull request
Jun 15, 2024
This reverts commit b60fb7b.
felixfontein
added a commit
that referenced
this pull request
Jun 15, 2024
|
#433 re-adds this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://forum.ansible.com/t/5084
Ref: ansible-collections/ansible-inclusion#70 (reply in thread)
I would suggest to wait a few days before merging this, in case we need to do an emergency 10.0.1 release for whatever (unexpected) reason. If we haven't done one in a few days it's safe to assume the next release will be 10.1.0, which accepts new features (and thus new collections).